Format Selection is formatting the entire file

[eeyorelee]

Format Selection is formatting the entire file

[EeyoreLee]

Seems there's a PR to fix it, upgrade your local yapf package when yapf merge it may fix it. Related PR yapf #1102

[EeyoreLee]

@lsouder-ozone3d - hi, has the formatOnSave affected you? Could you try the following setting for [python] section

  "[python]": {
    "editor.formatOnSave": false,
    "editor.defaultFormatter": "eeyore.yapf",
    "editor.formatOnType": false
  }

If there's still a unexpect problem, please show me a code snippet can reproduct this as I just try this on my side that seems working fine.

[lsouder-ozone3d]

@EeyoreLee thanks for responding. That config didn't solve the problem.

def do_something():
    xs = []
    for x in xs:
        y = 'y'
        
        if y:
            pass

def do_something_else():
    return '-path 1'

Line 5 has 2 unnecessary tabs. If I Format Selection for just the last line, it will strip the whitespace in Line 5

[EeyoreLee]

@lsouder-ozone3d - yup, I reproducted it not only through vscode extension but also yapf xx.py -l 10-10 -i. So it's a bug of yapf package. I'll issue it to yapf repo.

[lsouder-ozone3d]

@EeyoreLee Thanks for looking into that! I'll close out this issue and watch for a change over there.