Giter Site home page Giter Site logo

Comments (4)

manugoyal avatar manugoyal commented on August 24, 2024

Huh, yeah that does sound weird. I haven't heard of that before. Yeah any additional information about what all these symbols are would be helpful.

Another thing that could be helpful is to figure out if there is a commit that is causing this issue. Can you perform a git-bisect of some sort on the libcuckoo repository and see if there is a specific commit that introduces this behavior?

from libcuckoo.

ldalessa avatar ldalessa commented on August 24, 2024

So I'm not sure how helpful this will be, but the output from nm tests/unit/bcast | grep cuckoo > cuckoo.txt is attached for both the debug ("-O0 -g" and release ("-O3") builds. We regress both builds because we like to be able to see the stack trace from the jenkins debug build when things go south.

It's possible that this is just the natural consequence of using C++?

It's a bit hard for me to bisect because of the way we're integrated but I can try.

cuckoo_O0_g.txt
cuckoo_O3.txt

from libcuckoo.

manugoyal avatar manugoyal commented on August 24, 2024

Hmm looking through the symbols, they look like what I'd expect to see (mostly templated function definitions). I'm comparing the symbols from your O3 file and the symbol printout from the examples/hellohash, and they seem quite similar. I've attached my symbol printout (after running c++filt on it).

There were a couple symbols in your file I noticed that didn't show up in hellohash:

std::__shared_ptr<std::thread::_Impl<std::_Bind_simple<cuckoohash_map<void const*, unsigned long, CityHasher<void const*>, std::equal_to<void const*>, std::allocator<std::pair<void const* const, unsigned long> >, 4ul>::cuckoo_fast_double(unsigned long)::'lambda0'(unsigned long, unsigned long) (unsigned long, unsigned long)> >, (__gnu_cxx::_Lock_policy)2>::_Deleter<std::allocator<std::thread::_Impl<std::_Bind_simple<cuckoohash_map<void const*, unsigned long, CityHasher<void const*>, std::equal_to<void const*>, std::allocator<std::pair<void const* const, unsigned long> >, 4ul>::cuckoo_fast_double(unsigned long)::'lambda0'(unsigned long, unsigned long) (unsigned long, unsigned long)> > > >::operator()(std::thread::_Impl<std::_Bind_simple<cuckoohash_map<void const*, unsigned long, CityHasher<void const*>, std::equal_to<void const*>, std::allocator<std::pair<void const* const, unsigned long> >, 4ul>::cuckoo_fast_double(unsigned long)::'lambda0'(unsigned long, unsigned long) (unsigned long, unsigned long)> >*) (.isra.153.constprop.158)

and

std::_Sp_counted_deleter<std::thread::_Impl<std::_Bind_simple<cuckoohash_map<unsigned long, int, CityHasher<unsigned long>, std::equal_to<unsigned long>, std::allocator<std::pair<unsigned long const, int> >, 4ul>::cuckoo_fast_double(unsigned long)::'lambda0'(unsigned long, unsigned long) (unsigned long, unsigned long)> >*, std::__shared_ptr<std::thread::_Impl<std::_Bind_simple<cuckoohash_map<unsigned long, int, CityHasher<unsigned long>, std::equal_to<unsigned long>, std::allocator<std::pair<unsigned long const, int> >, 4ul>::cuckoo_fast_double(unsigned long)::'lambda0'(unsigned long, unsigned long) (unsigned long, unsigned long)> >, (__gnu_cxx::_Lock_policy)2>::_Deleter<std::allocator<std::thread::_Impl<std::_Bind_simple<cuckoohash_map<unsigned long, int, CityHasher<unsigned long>, std::equal_to<unsigned long>, std::allocator<std::pair<unsigned long const, int> >, 4ul>::cuckoo_fast_double(unsigned long)::'lambda0'(unsigned long, unsigned long) (unsigned long, unsigned long)> > > >, std::allocator<std::thread::_Impl<std::_Bind_simple<cuckoohash_map<unsigned long, int, CityHasher<unsigned long>, std::equal_to<unsigned long>, std::allocator<std::pair<unsigned long const, int> >, 4ul>::cuckoo_fast_double(unsigned long)::'lambda0'(unsigned long, unsigned long) (unsigned long, unsigned long)> > >, (__gnu_cxx::_Lock_policy)2>::_M_destroy()

The second type (__Sp_counted_deleter) occurred a bunch of times.

On my machine, the hellohash object file is 152KB and the executable is about 6KB. Is hellohash a very different size on your machine?

hellohash_symbols.txt

from libcuckoo.

ldalessa avatar ldalessa commented on August 24, 2024

Are you looking at the libtool wrapper? I see the following with the "release" (O3) build.

ldalessa@cutter:~/libcuckoo/examples$ ls -all .libs/
total 356
drwxr-xr-x 2 ldalessa research   4096 Nov 11 12:04 .
drwxr-xr-x 4 ldalessa research   4096 Nov 11 12:04 ..
-rwxr-xr-x 1 ldalessa research  94213 Nov 11 12:04 count_freq
-rwxr-xr-x 1 ldalessa research  70731 Nov 11 12:04 hellohash
-rwxr-xr-x 1 ldalessa research 181596 Nov 11 12:04 nested_table

and with -O0 -g (our jenkins issue) the hellohash is 1.28MB instead of 70k.

These numbers are okay I guess. I looked back in time a bit and it looks like the libcuckoo fraction of the binary size has been constant for quite some time, so I'll look elsewhere for a potential reason for any increase we're seeing.

Thanks,
Luke

from libcuckoo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.