Giter Site home page Giter Site logo

Comments (3)

huanchenz avatar huanchenz commented on August 29, 2024

Hey, thanks a lot for pointing this out. Seems like if I change the line to
&& louds_bits_->readBit(pos)) {
it would work.
What do you think?

from surf.

chenfucn avatar chenfucn commented on August 29, 2024

If I understand correctly, this is to judge whether 'pos' is the last label in a node. In that case what you propose does not work. I would suggest write another function

inline bool isEndOfNode(pos) { return pos == lastPosition || louds_bits_readBit(pos + 1); }

this way not only your code is more readable, you avoid code clone

from surf.

huanchenz avatar huanchenz commented on August 29, 2024

Thanks! I'll push a fix soon.

from surf.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.