Giter Site home page Giter Site logo

Comments (8)

Spleenftw avatar Spleenftw commented on September 28, 2024 1

So the normal behaviour should be :

base alacritty.yml :

font:
  size: 8
  offset:
    x: 0
    y: 1
window:
    opacity: 0.8
mouse:
  double_click: { threshold: 300 }
  triple_click: { threshold: 300 }
  hide_when_typing: true
selection:
  save_to_clipboard: true
cursor:
  style: Block
  unfocused_hollow: true

# BEGIN ACE
colors:
  primary:
    background: '#020204'
    foreground: '#808081'
  cursor:
    text:       '#020204'
    cursor:     '#808081'
  normal:
    black:      '#020204'
    red:        '#283455'
    green:      '#333f5a'
    yellow:     '#2b3766'
    blue:       '#3c4a73'
    magenta:    '#414987'
    cyan:       '#70516f'
    white:      '#808081'
  bright:
    black:      '#414142'
    red:        '#364672'
    green:      '#445579'
    yellow:     '#3A4A89'
    blue:       '#51639A'
    magenta:    '#5762B4'
    cyan:       '#966D94'
    white:      '#bfbfc0'
# END ACE

Launch the script.sh, and only the text between # BEGIN ACE and # END ACE should be switched with the new colors, right ?

Because the script is just removing this part and write the colors :

font:
  size: 8
  offset:
    x: 0
    y: 1
window:
    opacity: 0.8
mouse:
  double_click: { threshold: 300 }
  triple_click: { threshold: 300 }
  hide_when_typing: true
selection:
  save_to_clipboard: true
cursor:
  style: Block
  unfocused_hollow: true

from pywal2alacritty.

egeesin avatar egeesin commented on September 28, 2024

Sorry, can you give details about this part?

Sometimes it does change the color but put the config in double with one or two lines missing

Also do you have access to older version of your config so I can check if there's something wrong?

from pywal2alacritty.

Spleenftw avatar Spleenftw commented on September 28, 2024

Hello, i used the basic dracula colorscheme :

# Dracula theme for Alacritty
# https://draculatheme.com/alacritty
#
# Color palette
# https://spec.draculatheme.com
#
# Template
# https://github.com/alacritty/alacritty/blob/master/alacritty.yml

colors:
  primary:
    background: '#282a36'
    foreground: '#f8f8f2'
    bright_foreground: '#ffffff'
  cursor:
    text: CellBackground
    cursor: CellForeground
  vi_mode_cursor:
    text: CellBackground
    cursor: CellForeground
  search:
    matches:
      foreground: '#44475a'
      background: '#50fa7b'
    focused_match:
      foreground: '#44475a'
      background: '#ffb86c'
    bar:
      background: '#282a36'
      foreground: '#f8f8f2'
  hints:
    start:
      foreground: '#282a36'
      background: '#f1fa8c'
    end:
      foreground: '#f1fa8c'
      background: '#282a36'
  line_indicator:
    foreground: None
    background: None
  selection:
    text: CellForeground
    background: '#44475a'
  normal:
    black: '#21222c'
    red: '#ff5555'
    green: '#50fa7b'
    yellow: '#f1fa8c'
    blue: '#bd93f9'
    magenta: '#ff79c6'
    cyan: '#8be9fd'
    white: '#f8f8f2'
  bright:
    black: '#6272a4'
    red: '#ff6e6e'
    green: '#69ff94'
    yellow: '#ffffa5'
    blue: '#d6acff'
    magenta: '#ff92df'
    cyan: '#a4ffff'
    white: '#ffffff'

But it seems like it deleted what was written in the alacritty.yml (don't really care since i can find it on the net).

from pywal2alacritty.

Spleenftw avatar Spleenftw commented on September 28, 2024

I'm recording the behavior so you can see what's happening.

EDIT : here's the video : https://www.youtube.com/watch?v=1SV8bQGSi7g

from pywal2alacritty.

egeesin avatar egeesin commented on September 28, 2024

In the beginning of the video, # BEGIN ACE is in the line 1 and this is unintended since # BEGIN ACE and # END ACE supposed to surround only color related configurations as seen in README example, not all configurations.

If there isn't BEGIN/END comments (in other words, if this is your first time running this script), script should append these color configs generated by pywal without modifying existing Alacritty configs.

Was that # BEGIN ACE generated by the script in the line 1 at the first place?

from pywal2alacritty.

Spleenftw avatar Spleenftw commented on September 28, 2024
Was that # BEGIN ACE generated by the script in the line 1 at the first place?

Yes

from pywal2alacritty.

egeesin avatar egeesin commented on September 28, 2024

Hello, i used the basic dracula colorscheme :

# Dracula theme for Alacritty
# https://draculatheme.com/alacritty[](https://draculatheme.com/alacritty)
#
# Color palette
# https://spec.draculatheme.com[](https://spec.draculatheme.com)
#
# Template
# https://github.com/alacritty/alacritty/blob/master/alacritty.yml[](https://github.com/alacritty/alacritty/blob/master/alacritty.yml)

colors:
  primary:
    background: '#282a36'
    foreground: '#f8f8f2'
    bright_foreground: '#ffffff'
  cursor:
    text: CellBackground
    cursor: CellForeground
  vi_mode_cursor:
    text: CellBackground
    cursor: CellForeground
  search:
    matches:
      foreground: '#44475a'
      background: '#50fa7b'
    focused_match:
      foreground: '#44475a'
      background: '#ffb86c'
    bar:
      background: '#282a36'
      foreground: '#f8f8f2'
  hints:
    start:
      foreground: '#282a36'
      background: '#f1fa8c'
    end:
      foreground: '#f1fa8c'
      background: '#282a36'
  line_indicator:
    foreground: None
    background: None
  selection:
    text: CellForeground
    background: '#44475a'
  normal:
    black: '#21222c'
    red: '#ff5555'
    green: '#50fa7b'
    yellow: '#f1fa8c'
    blue: '#bd93f9'
    magenta: '#ff79c6'
    cyan: '#8be9fd'
    white: '#f8f8f2'
  bright:
    black: '#6272a4'
    red: '#ff6e6e'
    green: '#69ff94'
    yellow: '#ffffa5'
    blue: '#d6acff'
    magenta: '#ff92df'
    cyan: '#a4ffff'
    white: '#ffffff'

But it seems like it deleted what was written in the alacritty.yml (don't really care since i can find it on the net).

When I've this in my .config/alacritty/alacritty.yml and running the script I got this:

# Dracula theme for Alacritty
# https://draculatheme.com/alacritty
#
# Color palette
# https://spec.draculatheme.com
#
# Template
# https://github.com/alacritty/alacritty/blob/master/alacritty.yml

colors:
  primary:
    background: '#282a36'
    foreground: '#f8f8f2'
    bright_foreground: '#ffffff'
  cursor:
    text: CellBackground
    cursor: CellForeground
  vi_mode_cursor:
    text: CellBackground
    cursor: CellForeground
  search:
    matches:
      foreground: '#44475a'
      background: '#50fa7b'
    focused_match:
      foreground: '#44475a'
      background: '#ffb86c'
    bar:
      background: '#282a36'
      foreground: '#f8f8f2'
  hints:
    start:
      foreground: '#282a36'
      background: '#f1fa8c'
    end:
      foreground: '#f1fa8c'
      background: '#282a36'
  line_indicator:
    foreground: None
    background: None
  selection:
    text: CellForeground
    background: '#44475a'
  normal:
    black: '#21222c'
    red: '#ff5555'
    green: '#50fa7b'
    yellow: '#f1fa8c'
    blue: '#bd93f9'
    magenta: '#ff79c6'
    cyan: '#8be9fd'
    white: '#f8f8f2'
  bright:
    black: '#6272a4'
    red: '#ff6e6e'
    green: '#69ff94'
    yellow: '#ffffa5'
    blue: '#d6acff'
    magenta: '#ff92df'
    cyan: '#a4ffff'
    white: '#ffffff'
# BEGIN ACE
colors:
  primary:
    background: '#180f18'
    foreground: '#cbc2e1'
  cursor:
    text:       '#180f18'
    cursor:     '#cbc2e1'
  normal:
    black:      '#180f18'
    red:        '#6A538E'
    green:      '#464AAB'
    yellow:     '#916A98'
    blue:       '#C569B5'
    magenta:    '#EBB0B2'
    cyan:       '#AD93D5'
    white:      '#cbc2e1'
  bright:
    black:      '#8e879d'
    red:        '#6A538E'
    green:      '#464AAB'
    yellow:     '#916A98'
    blue:       '#C569B5'
    magenta:    '#EBB0B2'
    cyan:       '#AD93D5'
    white:      '#cbc2e1'
# END ACE

As I said, the ACE block should append without modifying over existing configuration if you running it for the first time. But if there's existing # BEGIN ACE, # END ACE comments in the wrong place before the execution, this can corrupt the configuration file. I'm unable to reproduce your issue.

from pywal2alacritty.

egeesin avatar egeesin commented on September 28, 2024

Correct. If anything still goes wrong let me know with the reproduction steps so I can know where to look exactly.

from pywal2alacritty.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.