Silent failure when 1-n Node.js versions don't have a binary for a given OS+architecture

[ehmicky]

Silent failure when 1-n Node.js versions don't have a binary for a given OS+architecture

[ehmicky]

This is now fixed in 16.0.1! 🎉
Thanks for reporting this bug.

[ehmicky]

Hi @ericcornelissen,

Thanks for reporting this.
The problem seems to be that, after one of the downloads fails, the progress bars of the other downloads keep going. Therefore, the progress bar updates of the terminal overwrites the error message.
This should be fixed by adding a signal option to fetch-node-website, so that nve can abort any ongoing download when it catches an exception.

You'll notice this by passing the --no-progress option, which prevents the bug from appearing then.

nve --no-progress 10.13.0,12,14,16,18,19,20 some-command

Thanks for the issue.

[ericcornelissen]

The problem seems to be that, after one of the downloads fails, the progress bars of the other downloads keep going. Therefore, the progress bar updates of the terminal overwrites the error message. This should be fixed by adding a signal option to fetch-node-website,

That makes sense

so that nve can abort any ongoing download when it catches an exception.

As a suggestion, I think it would make sense to provide the user with the ability to either "ignore" or "not ignore" any failures due to missing platform binaries. For my use case, I would like nve not to fail, but output a warning instead.

You'll notice this by passing the --no-progress option, which prevents the bug from appearing then.

nve --no-progress 10.13.0,12,14,16,18,19,20 some-command

Verified this and you're correct.

[ehmicky]

@all-contributors Could you please add @ericcornelissen for bug?

[allcontributors]

@ehmicky

I've put up a pull request to add @ericcornelissen! 🎉