(libretro) Enhanced CD audio support

[ekeeke]

(libretro) Enhanced CD audio support

[ekeeke]

Yes, the emulator automatically try to load the .iso file when this game is detected: the ISO file must be named the same as the ROM file and be in the same directory.
Standalone version let you load the CD image file manually when asked by the game but that's not possible in Retroarch.

[andres-asm]

You're quite right it just works if you have the ISO alongside the rom.
It doesn't work if the rom file is compressed though.

And there is a subsystem api that allows these uncommon use cases (useful to combine roms or whatever, will be implemented in TGB dual eventually) it still lacks frontend support though but I thought it was worth mentioning

[ekeeke]

It will work as long as the name of the .iso file is the same as the filename passed as argument to load_rom function, which in libretro port corresponds to info->path sent by the retro_load_game API function.

File decompression is handled externally from the core by Retroarch, so if it changes the name of the ROM file inside the .zip after decompressing it or if that name did not match the .iso filename, this is likely where your issue comes from.

[andres-asm]

Nope, I verified that.

There have been some changes to the decompression stuff (7z support, multi file archives, etc) so that might be the issue I'll do more testing, maybe it's extracting to extraction dir instead now.

Thanks for the help 👍

[sergiobenrocha2]

This feature only work in RA if you change the extension of the unzipped file from .md to .bin (and I have the same name for both rom and iso files). Does someone have an idea why it happens?

[andres-asm]

I think that's the way the developer intended it to work, it's not libretro related
it's the same on the Wii IIRC

On Sun, Jan 18, 2015 at 7:22 PM, Sérgio Benjamim [email protected]
wrote:

This feature only work in RA if you change the extension of the unzipped
file from .md to .bin (and I have the same name for both rom and iso
files). Does someone have an idea why it happens?

—
Reply to this email directly or view it on GitHub
#34 (comment)
.

[ekeeke]

Hum, no, the extension of ROM file should not matter, it is indeed a bug in loadrom.c where it assumes the ROM extension is always 3 characters

[ekeeke]

This was fixed by bb53892

[andres-asm]

There is some oddity with this. I'm testing on windows 64bit.
I load retroarch like this:
retroarch --menu --verbose -c configs/andres.cfg

And it doesn't work even though the config only has this:
libretro_directory = ":\libretro"
libretro_info_path = ":\libretro"

If I just load retroarch with no arguments and the same config file in retroarch's location then it works
Again, for testing purposes the config only has this:
libretro_directory = ":\libretro"
libretro_info_path = ":\libretro"

[andres-asm]

Found the issue, this functionality doesn't like relative paths for the rom location

[ekeeke]

Indeed, the code now looks for the first occurence of '.' character to detect where the file extension starts, instead of just replacing the last 3 characters like it did before (which didn't work for .md files). So if the romfile path starts with "../" or "./", it won't work.

I had assumed the frontend would always pass the full path or that there can't be '.' character in directory names, which is a little bit unsafe. This can easily be fixed though, I will try to think about a safer solution.

[andres-asm]

Cool, wouldn't it be better to look for the last "."?

[ekeeke]

Should be better in 935a1f6