Comments (5)
I've run into this in the past, I think it's just the Name
tag that causes the conflict. Removing all the tags would be the easiest approach, I don't immediately see a downside to this approach.
The other option would be to rename the instance to indicate it was terminated by aws-nuke, but that introduces a few extra checks that would have to happen.
from aws-nuke.
@Petersoj when you are working on a PR it's fine generally speaking. You just don't want to be doing force pushes on primary branches/release branches, etc where others are working or where the history is at, when it comes to a new feature and doing a PR, force pushes are normal, because you might amend commits or rebase of the current main branch to make sure you are up to date or to resolve conflicts, etc.
from aws-nuke.
Yeah I imagine removing all the tags on an EC2 instance would fix this issue and not cause any unintended issues.
PR for it: #141 (my first time working in Go which was pretty fun)
from aws-nuke.
hey @Petersoj thanks for your PR, sounds like I need to write up some documentation on how to edit your previous commits so you don't have to close out and re-open, you can always edit and force push to make changes like signing or message syntax.
from aws-nuke.
Yeah I was considering force pushing, but I was reading up on how that isn't the best practice in most cases. Perhaps it was permissible in this case though.
from aws-nuke.
Related Issues (20)
- Filter properties are not respected HOT 7
- Review Resources for Tag Support HOT 18
- Need to support --max-wait-retries option HOT 2
- Add support for Glue SecurityConfiguration HOT 2
- [secrets manager] need to delete replicas first before primary
- [secrets manager] need to exclude aws managed secrets
- [docs] add example config templates
- [idea] use aws resource groups tagging api to retrieve tags for bulk of resources HOT 3
- Merge Upstream PRs HOT 8
- Issues when AWS_DEFAULT_REGION is set as an env var HOT 12
- Direct docker build image binary does not work HOT 2
- [idea] structured logs/report HOT 4
- [idea] IaC quick start for scheduled deletion HOT 2
- Add support for SageMaker Space Apps and Spaces HOT 6
- Add Bedrock resources
- feature: add bypass prod string in alias check HOT 4
- SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x42664b6 HOT 6
- Replace AWS SDK with AWS SDK v2 HOT 1
- Parallel Execution
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-nuke.