Comments (9)
Hi, i would like to work on this.
I think that i should work on the truncate.js file and use the onObject callback (where i have access to the key) instead of the onValue (which is the one truncating now).
Right?
from apm-nodejs-http-client.
It might be achievable with onObject
. It could be a bit of a challenge though as it's a bit tough to wrap your brain around the nested filter stuff--you could very easily blow away your own changes or send it into an infinite loop and blow the stack. Feel free to ask questions here if you get stuck and I'll do what I can to help. 👍
from apm-nodejs-http-client.
Hi, i started looking for this and I'm not sure what the expectation is.
If I take as an expample the truncateSpan function you expect that, given an input span like this:
{
foo: "bar",
}
and an option that sets the max key length to 2 the output should be:
{
fo: "bar",
}
Correct?
from apm-nodejs-http-client.
Yes. Recursively, all keys should be shortened. One challenge that we never put much thought into how to handle is what to do about collisions. For example, shortening a1
and a2
to key length 1 would result in two different values for a
--which one should it finally be? I'm not really sure. 🤔
from apm-nodejs-http-client.
I would consider just truncating the keys that are controlled by the user. Might be easier on the CPU
from apm-nodejs-http-client.
Ok, but the issue regarding the collisions remains right?
from apm-nodejs-http-client.
Yes, collisions are still possible.
from apm-nodejs-http-client.
Just created a PR
It is not complete yet but i think it could be useful to make me understand if i'm on the right way
Let me know ;)
from apm-nodejs-http-client.
Closed by #92.
from apm-nodejs-http-client.
Related Issues (20)
- Node 11 support HOT 2
- TypeError: Cannot convert undefined or null to object HOT 2
- Cannot get this to send out spans HOT 2
- Non-standard indentation and undefined catch scope HOT 6
- Indentation with EsLint and Prettier HOT 2
- Need to increment git ignore configuration HOT 5
- test failure with node v15.5.0 HOT 1
- Kibana Instrumentation and `APM Server transport error (ECONNRESET): socket hang up` Log Messages HOT 14
- perf: Alternate Options to Initial Stream Corking
- Feature Request: Logging in the Client HOT 1
- Flush seems to complete before request is sent HOT 5
- Blocking Behavior under Benchmarking Load HOT 11
- consider changing payloadLogFile handling to *not* unzip the payload data HOT 1
- 'npm run coverage' errors; breaks checks for node v15 HOT 1
- `client.flush(cb)` callback may not be called in v9.7.0 HOT 1
- Client Behavior in AWS Lambda Enviornment
- CI implementations (in GitHub actions and Jenkinis) duplicate the number of builds per PR HOT 2
- Audit failure due to a vulnerability in semver HOT 1
- Vulnerability in semver HOT 1
- Throws error `Cannot read property 'length' of undefined` on StreamChopper.Writable.write() HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apm-nodejs-http-client.