Giter Site home page Giter Site logo

Comments (4)

Qard avatar Qard commented on June 16, 2024

What are you sending that's that big? That's an out-of-memory error. 🤔

Can you share more details about what the individual span/transaction object looks like and why it's so big?

from apm-nodejs-http-client.

SimonSimCity avatar SimonSimCity commented on June 16, 2024

Well, it's related to the issue I referred to (https://github.com/kschingiz/meteor-elastic-apm/pull/34) - which is kind of a longer story.

We're monitoring a framework called Meteor, which provides the option to send "commands" (they refer to it as calling a method) over the wire. All of those are logged including their data. Imagine calling a save method giving it some parameters - the name of the method and the parameters are sent to the server via a socket connection.

Now - one of the packages uses this technology to upload files. It splits the file up into chunks on the server side and then sends partial-upload-calls to the server containing the files content as argument; and this method (and thereby also it's logging including the full parameters) is called very often within a second. This brings this library to crash.

It's one side of a coin that this clearly is not as this library was intended to be used, but it also surprises me that this library doesn't have a security layer in place here to prevent the system from crashing.

from apm-nodejs-http-client.

SimonSimCity avatar SimonSimCity commented on June 16, 2024

I found some resources saying a string in nodejs has a maximum length (nodejs/help#712). It could well be that this already will postpone the problem by such a margin that it doesn't affect us anymore, but I guess it'll come back one day 😄

from apm-nodejs-http-client.

Qard avatar Qard commented on June 16, 2024

Yes, there is a max string size in JavaScript itself, and there's nothing we can do about that. We do have a bunch of protections in place to avoid crashing the process, but there's not a whole lot that can be done when the process runs out of memory. 🤷‍♂

from apm-nodejs-http-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.