goproxy and transparent mode

[elazarl]

goproxy and transparent mode

[elazarl]

Hi,

Thanks for the kind words, and thanks for reporting the bug.

Can you write a more detailed, step-by-step instructions how to recreate the problem?

Thanks,

Here it is:

// On my router

$ iptables -t nat -A PREROUTING -p tcp --dport 80 -j REDIRECT --to-port 8080
$ cat main.go
package main

import (
"github.com/elazarl/goproxy"
"log"
"net/http"
)

func main() {
proxy := goproxy.NewProxyHttpServer()
proxy.OnResponse().DoFunc(
func(resp *http.Response, ctx *goproxy.ProxyCtx) *http.Response {
log.Println("Resp = ", resp)
return resp
})
proxy.Verbose = true
log.Fatal(http.ListenAndServe(":8080", proxy))
}

// At other side I'm starting chromium without proxy, and get this: unsupported protocol scheme ""

$ go run *
2013/12/03 18:28:43 [001] INFO: Got request GET /
2013/12/03 18:28:43 [001] INFO: Sending request GET /
2013/12/03 18:28:43 Resp =
2013/12/03 18:28:43 [001] INFO: error read response unsupported protocol scheme "":
2013/12/03 18:28:43 [002] INFO: Got request GET /favicon.ico
2013/12/03 18:28:43 [002] INFO: Sending request GET /favicon.ico
2013/12/03 18:28:43 Resp =
2013/12/03 18:28:43 [002] INFO: error read response unsupported protocol scheme "":

[elazarl]

@alxchk

Can you test it now, and let me know if it works for you?

Thanks,

Unfortunately, issue stil present:

$ go run *
2013/12/04 11:15:29 [001] INFO: Got request / ya.ru GET /
2013/12/04 11:15:29 [001] INFO: Sending request GET http://ya.ru/
2013/12/04 11:15:29 Resp =
2013/12/04 11:15:29 [001] INFO: error read response unsupported protocol scheme "":
2013/12/04 11:15:30 [002] INFO: Got request /favicon.ico ya.ru GET /favicon.ico
2013/12/04 11:15:30 [002] INFO: Sending request GET http://ya.ru/favicon.ico
2013/12/04 11:15:30 Resp =
2013/12/04 11:15:30 [002] INFO: error read response unsupported protocol scheme "":
2013/12/04 11:15:35 [003] INFO: Got request / linux.org.ru GET /
2013/12/04 11:15:35 [003] INFO: Sending request GET http://linux.org.ru/
2013/12/04 11:15:35 Resp =
2013/12/04 11:15:35 [003] INFO: error read response unsupported protocol scheme "":

And in browser:
unsupported protocol scheme ""

network dump: http://ge.tt/3EqEK771/v/0

Here is the fix: http://ix.io/9fq

[elazarl]

@alxchk ,

Thanks for submitting the patch. I've tried a somewhat different approach.

Can you please check and see if the new version works for you?

THanks,

Works ok, many thanks!