support http connect method

[elazarl]

support http connect method

[elazarl]

Hi,

Thanks for using goproxy.

Yes. This is the expected behavior.
curl -p will issue a CONNECT request to the remote site baidu.com, would get a direct connection, and then

If you want, you can either disable CONNECT requests, or, apply MITM techniques to capture the CONNECT request.

It is currently not possible to MITM a generic TCP connection, but I'm working and thinking on a solution now. Feel free to write suggestions for how to do that.

MITM connect request is also relevant for websockets.

Did you expect anything else? Is disabling CONNECT requests to port 80 a good enough solution for you?

[zhangpy]

What I want is to modify response html content in such case.

Can you show me a demo code how to disable CONNECT request? I could try it.
And my web server is 8080 instead of 80.

[elazarl]

Did that solve your problem?

Thanks,

[zhangpy]

No. this will give exception in console, and the response is not modified. (failed to connect.)

INFO: Running 2 CONNECT handlers
2014/04/03 22:46:08 [002] INFO: handler: &{0 } www.baidu.com:80
2014/04/03 22:46:08 [002] INFO: handler: &{2 } www.baidu.com:80
2014/04/03 22:46:08 [002] INFO: Assuming CONNECT is TLS, mitm proxying it
2014/04/03 22:46:08 [002] WARN: Cannot handshake client www.baidu.com:80 local error: unexpected message

It seems disable http CONNECT request will fail all connection. It will try to use ssl to connect target web site, but the website does not support.

Could we apply MITM techniques to capture the CONNECT request and modify response?

[elazarl]

Can you explain what is the expected behavior? I'm not sure I understand it.

What are the curl commands, and what is the expected output?

[zhangpy]

I expect that goproxy could proxy the page correctly with my modification (like add alert script at the end of page - shows in demo code) in this case:
curl -v -p --proxy localhost:7000 http://www.baidu.com

[elazarl]

I think I understand. I'll add a way to "Hijack" CONNECT requests in a few minutes.

[elazarl]

Please let me know if it works for you, see the eavesdropper example.

You can test it with curl -p and it should work.

Did that work for you?

Thanks,

[zhangpy]

It works. thanks.
I make some change and send a pull request. please review. thanks.