Use HTTP 1.1 for ConnectAccept case

[elazarl]

Use HTTP 1.1 for ConnectAccept case

[elazarl]

Hi @simathur, thanks for using goproxy.

When replying to a CONNECT request, the proxy is expected to create a tunnel. That is, to send any bytes sent to the proxy to the remote site, and send any bytes coming from the remote site back to the client.

So it cannot reuse the connection, and would not use any HTTP, 1.1, or 1.0.

Does that make sense, or am I misunderstanding the question?

[s8mathur]

Thanks for the clarification, I understand conceptually. Though, I am still wondering what the following code block does in the ConnectAccept case block in handleHttps(). It does seem to be sending a HTTP 1.0 preamble to the upstream server, no?

ctx.Logf("Accepting CONNECT to %s", host)
proxyClient.Write([]byte("HTTP/1.0 200 OK\r\n\r\n"))
go copyAndClose(ctx, targetSiteCon, proxyClient)
go copyAndClose(ctx, proxyClient, targetSiteCon)

Thanks for your code and time!

[elazarl]

While the standard doesn't seem to mandate a particular HTTP version for the response[0], in practice I've seen that proxies use HTTP/1.0, so I'm trying to stick with that. Here, have a look at squid proxy which have the HTTP/1.0 response hardwired in code.

[0]

5.3 Establishing a Tunnel with CONNECT

Any successful (2xx) response to a CONNECT request indicates that the
proxy has established a connection to the requested host and port,
and has switched to tunneling the current connection to that server
connection.

It may be the case that the proxy itself can only reach the requested
origin server through another proxy. In this case, the first proxy
SHOULD make a CONNECT request of that next proxy, requesting a tunnel
to the authority. A proxy MUST NOT respond with any 2xx status code
unless it has either a direct or tunnel connection established to the
authority.

[s8mathur]

Thanks for the explanation. BTW, do you hang around on IRC/#go-nuts sometimes? My nick is "simathur" when I am on IRC.

[elazarl]

Unfortunately I don't use IRC frequently. Should I?

On Wed, May 7, 2014 at 8:10 AM, simathur [email protected] wrote:

Thanks for the explanation. BTW, do you hang around on IRC/#go-nuts
sometimes? My nick is "simathur" when I am on IRC.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/47#issuecomment-42390114
.