Comments (6)
@elbowz - I recommend using message.get('title','') instead for items that might not be there, like in my fix eee437a. There may be other places where we might want to do this because a lot of push fields are optional.
from xbmc.service.pushbullet.
Fixed here e7981bc (I hope)
@grenryd - Again wait next 0.8.18b...and sorry again for the regression bug
@ruuk - You have right, I didn't know the dict.get()
method with fallback default value. I did not done check (in the previous release) because I thought that was impossible there was a android notification without a title... I have mistake, Samsung have done one of it ;)
Take a look if now is it good? ...and always feel free to fix or correct my code. I like to learn as I said you :)
edit: if you want postpone 0.8.18b release for me it's ok...I think we do too many releases with few changes, and this is not a major bug...how do you prefer
from xbmc.service.pushbullet.
I think I will put it on my repository, as it was a user reported bug.
Also, I'm probably going to create another repository. I want to use it for pre-release/alpha/testing versions. It's useful for me because it makes it easier to get things I'm testing onto all my other devices, plus we can link to the zips there if we need a user to test something, but we would otherwise use it internally. I'll be adding it for use with my other addons in any case.
Also, I was wondering if you think we should drop the b and do more normal versions.
Example:
- 0.10.0a2 <- Private version (on my alpha repo)
- 0.10.0a4 <- Private versions (on my alpha repo)
- At this point we decide we wan't to stop adding things and prepare for release
- 0.10.0b2 <- On my current repo (beta)
- 0.10.0b4 <- On my current repo (beta)
- 0.10.0 <- Release to offical repository
- A significant bug is found
- 0.10.2b2 <- On my current repo (beta)
- Bug fix is fine
- 0.10.2 <- Release to offical repository
Or something like that?
from xbmc.service.pushbullet.
Hi
I have been testing the latest code and all bugs are gone. Everything work as normal now. Great work guys. Big thanks !
PS it still shows version 0.8.16b in addon.xml
from xbmc.service.pushbullet.
PS it still shows version 0.8.16b in addon.xml
Actually I just changed it about 5 minutes ago :)
Also, thanks for taking the time to test it directly from GitHub.
from xbmc.service.pushbullet.
@grenryd - say hello to your girlfriend ;)
@ruuk - I see that you have preserve the even number :)
I like your solution, and I don't have nothing to do in this revolution...
At the end for me is ok!
A (unrelated) question: How to develop? I mean the working directory...
Before work in a team, I had a symlink in .xbmc/addons that point on my real project working directory (with .git folder and others stuff of my ide).
But now, If you release a new version and I start Kodi, all my project is overwritten and I lose .git (etc..)
from xbmc.service.pushbullet.
Related Issues (20)
- Send notifications? HOT 6
- no attribute 'encode' HOT 30
- Playback issues HOT 57
- Action on pushes dismissed (Android) HOT 11
- Gap on XBMC/Kodi closing HOT 3
- Push media don't playback HOT 11
- Service dies on network disconnect/suspend HOT 13
- Service does not connect to push server after authentication - requires Kodi restart HOT 4
- Socket disconnection causing service to stop HOT 4
- the number of caller, in android stock is in the notification title HOT 12
- Pushed sent to all devices automatically dismissed by plugin: Version 081b HOT 16
- trouble with russian characters (thins thouble with non english characters) HOT 2
- "View Channels" not working HOT 1
- [Feature Request] Switch subtitle on push
- [Feature Request] Add to playlist HOT 1
- Hebrew support HOT 1
- Hebrew default language HOT 4
- EOF occurred in violation of protocol (_ssl.c:590) HOT 12
- Kodi Repository HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xbmc.service.pushbullet.