[VAX-971] client: Leaky resources (Notifier subscriptions, EventEmitter listeners...)

[electric-sql]

[VAX-971] client: Leaky resources (Notifier subscriptions, EventEmitter listeners...)

[balegas]

I think close would be a destructive call and self-deregister from the registry.
I haven't yet got my head in the space for working on this, but is on my list :)

[balegas]

This patch #548 ticks the second box.

[kevin-dp]

PR #703 ticks the first box and adds a unit test to check that all listeners are disposed when closing the Electric client.

[thruflo]

@balegas it would be good to cross reference this issue report with the improvements we’ve made since to tidy up subscription cleanup and your work on reconnect etc.

Is there more to do or do you think this has been addressed now?

[balegas]

Hei, we’ll look into this and report here

[davidmartos96]

Another design question. Should the ElectricClient/Namespace close also close the Satellite process from the registry? Or is it something that the user would need to call additionally?

[davidmartos96]

I guess this could be closed now that all is merged.
Thank you! 😄