Interacting with developer variables break querying internal

[electricui]

Interacting with developer variables break querying internal

[Scottapotamas]

I've been able to reproduce the first, second, and third error case when using the terminal.

As far as I can tell with a logic analyser, the terminal is outputting what it says it is, and the micro is responding with the error. The actual generation of data by the terminal also seems correct at a glance.

Looking into this.

[Scottapotamas]

So the inbound message was parsed and passed up to the application layer, which was failing to 'find' the stored object in the internal array. After some tedious poking, I found that (for sub-max length msgIDs) the ID was retaining one or more characters of the last ingested message.

At some stage (late 2017 parser?) there was null termination added for the "current byte + 1" position. In the current rendition of the parser, I post incremented the counter for msgID bytes, and then perform processing logic.

As such, for shorter msgID's, I was null terminating one character too late, leaving a byte which caused a correct error in the application level search.

This has been resolved in 9959d07.

Feel free to close this issue once you validate everything works.

[Mike-Dax]

Validated, nice work.