Comments (6)
Please give 25.0.1 a shot and lemme know how it goes! Was no longer able to reproduce with the applied changes
from electron-builder.
25.0.1 solved the issue, thanks!
from electron-builder.
@gzdunek can you share the patch you are using?
Also, (hopefully) to temporarily unblock you, you may be able to use electron-builder config option nativeRebuilder: legacy
to leverage the previous app-builder-bin go binary for rebuilding native dependencies.
from electron-builder.
Here is the patch:
diff --git a/node_modules/app-builder-lib/out/util/yarn.js b/node_modules/app-builder-lib/out/util/yarn.js
index d4a95ba..a2ab75b 100644
--- a/node_modules/app-builder-lib/out/util/yarn.js
+++ b/node_modules/app-builder-lib/out/util/yarn.js
@@ -169,6 +169,7 @@ async function rebuild(config, appDir, options) {
debug: builder_util_1.log.isDebugEnabled,
projectRootPath: await (0, search_module_1.getProjectRootPath)(appDir),
mode: config.nativeRebuilder || "sequential",
+ disablePreGypCopy: true
};
if (buildFromSource) {
rebuildOptions.prebuildTagPrefix = "totally-not-a-real-prefix-to-force-rebuild";
Also, (hopefully) to temporarily unblock you, you may be able to use electron-builder config option nativeRebuilder: legacy to leverage the previous app-builder-bin go binary for rebuilding native dependencies.
Well, we had troubles with that too :)
In our monorepo setup (yarn 1.x) the legacy builder didn't find the native dependency at all (in the debug mode it logs no native dependencies
). Because of that, in the universal package, the dependency wasn't rebuilt for x86 arch and the app crashed in the runtime.
This seems to be a regression too, it worked fine in [email protected]
.
from electron-builder.
Thanks for the patch info!
I'm wondering if we should always disablePreGypCopy: true
for the electron/rebuild integration. I haven't seen other reports yet for this issue, but current adoption of 25.0.0 is fairly low atm (only 624 downloads as of this moment)
from electron-builder.
Thank you for the test repo. I've opened a PR to resolve this issue since I was also able to reproduce and updated a unit test to cover the universal mac packaging with node-pty
. Just updating test snapshots now
from electron-builder.
Related Issues (20)
- AutoUpdater doesn't detect latest-mac.yml from github HOT 3
- How to customize the log output file location HOT 1
- How to change output folder's name? HOT 3
- Accidental issue created
- Building for Windows on macOS creates broken builds. HOT 11
- Cannot overwrite installation if the uninstaller.exe is present, have to delete it manually HOT 2
- Builder in 25.0.0 finds files outside project and throws error HOT 2
- ERR_ELECTRON_BUILDER_CANNOT_EXECUTE: "could not open file: ....nsis\include\allowOnlyOneInstallerInstance.nsh" HOT 5
- How to support resumable download?
- v25.0.0 breaks linux AppImage build HOT 8
- Auto Update without Admin and perMachine: true HOT 1
- unbantu environment node-usb in electron-builder A native build error occurred when executing the electron-builder --win --ia32 command HOT 5
- After the builder is successful, there is an error when using cmd.exe to start the exe file.
- customInstall wrong ${isUpdated} value HOT 5
- [query] [electron-updater] Why is a subset of linux distros supported for autoupdates? HOT 29
- Having some dependencies in the package node_modules break the build HOT 4
- PortableOptions link lose HOT 1
- electron builder Please specify 'version' in the package.json HOT 1
- Not able to Pass Transporter & Notarization with same .pkg file HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron-builder.