Giter Site home page Giter Site logo

Comments (6)

mmaietta avatar mmaietta commented on August 23, 2024 1

Please give 25.0.1 a shot and lemme know how it goes! Was no longer able to reproduce with the applied changes

from electron-builder.

gzdunek avatar gzdunek commented on August 23, 2024 1

25.0.1 solved the issue, thanks!

from electron-builder.

mmaietta avatar mmaietta commented on August 23, 2024

@gzdunek can you share the patch you are using?

Also, (hopefully) to temporarily unblock you, you may be able to use electron-builder config option nativeRebuilder: legacy to leverage the previous app-builder-bin go binary for rebuilding native dependencies.

from electron-builder.

gzdunek avatar gzdunek commented on August 23, 2024

Here is the patch:

diff --git a/node_modules/app-builder-lib/out/util/yarn.js b/node_modules/app-builder-lib/out/util/yarn.js
index d4a95ba..a2ab75b 100644
--- a/node_modules/app-builder-lib/out/util/yarn.js
+++ b/node_modules/app-builder-lib/out/util/yarn.js
@@ -169,6 +169,7 @@ async function rebuild(config, appDir, options) {
         debug: builder_util_1.log.isDebugEnabled,
         projectRootPath: await (0, search_module_1.getProjectRootPath)(appDir),
         mode: config.nativeRebuilder || "sequential",
+        disablePreGypCopy: true
     };
     if (buildFromSource) {
         rebuildOptions.prebuildTagPrefix = "totally-not-a-real-prefix-to-force-rebuild";

Also, (hopefully) to temporarily unblock you, you may be able to use electron-builder config option nativeRebuilder: legacy to leverage the previous app-builder-bin go binary for rebuilding native dependencies.

Well, we had troubles with that too :)
In our monorepo setup (yarn 1.x) the legacy builder didn't find the native dependency at all (in the debug mode it logs no native dependencies). Because of that, in the universal package, the dependency wasn't rebuilt for x86 arch and the app crashed in the runtime.
This seems to be a regression too, it worked fine in [email protected].

from electron-builder.

mmaietta avatar mmaietta commented on August 23, 2024

Thanks for the patch info!

I'm wondering if we should always disablePreGypCopy: true for the electron/rebuild integration. I haven't seen other reports yet for this issue, but current adoption of 25.0.0 is fairly low atm (only 624 downloads as of this moment)

from electron-builder.

mmaietta avatar mmaietta commented on August 23, 2024

Thank you for the test repo. I've opened a PR to resolve this issue since I was also able to reproduce and updated a unit test to cover the universal mac packaging with node-pty. Just updating test snapshots now

from electron-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.