defualt ignore files config could not exclude node_modules in packing progress

[gweesin]

defualt ignore files config could not exclude node_modules in packing progress

[mmaietta]

If you want the size to be reduced, I'd recommend removing the unnecessary locales for electron.

This should already be supported via electronLanguages string array 🙂
https://www.electron.build/configuration/configuration

[beyondkmp]

The asar file needs to include node_modules, but it will only include the dependencies listed in your project's package.json and their dependencies. If you directly filter out all of node_modules, the code may not run unless you've bundled all the dependency code into the dist folder.

[gweesin]

Could I consider that all projects need to be bundled? Otherwise the app will contain the electron package in node_modules, it's about 256MB and it's duplicated and not used.

[xyloflake]

Could I consider that all projects need to be bundled? Otherwise the app will contain the electron package in node_modules, it's about 256MB and it's duplicated and not used.

If you want the size to be reduced, I'd recommend removing the unnecessary locales for electron.

Here's how I patched electron-builder to only include the English locale unless specified otherwise. This resulted in a 38MB unpackaged app size decrease.

staniel359/muffon#173

[xyloflake]

Otherwise the app will contain the electron package in node_modules, it's about 256MB and it's duplicated and not used.

Electron package in node modules is NOT a duplicate. It provides bindings to call the electron application through js. If you remove them, you won't be able to call the ABI methods through JS like you do. For example creating a new BrowserWindow.

The other electron package you're referring to provides the ABI through which the node js electron package can call methods that have been defined in the ABI.

[gweesin]

I have tried ignore node_modules directly, nothing happened.
and try to configure electronLanguages, then the package bundle size reduce.