getWindowWidth and getWindowHeight have null response.value when using the Tape test framework

[electron-userland]

getWindowWidth and getWindowHeight have null response.value when using the Tape test framework

[kevinsawicki]

Hmm, that is really strange that the response value would be null.

I might need to see your example to be able to debug it further.

I tried the following test using the sample app loaded from electron-prebuilt and did see it pass:

var Application = require('spectron').Application
var path = require('path')
var test = require('tape')

test('getWindowWidth test', function (t) {
    t.plan(1)

    var app = new Application({
      path: path.join(__dirname, 'node_modules', '.bin', 'electron')
    })

    app.start().then(function () {
      app.client.getWindowWidth().then(function (width) {
        t.equal(width, 800)
      }).then(function () {
        app.stop()
      }, function () {
        app.stop()
      })
    })
});

> tape test.js 
TAP version 13
# getWindowWidth test
ok 1 should be equal

1..1
# tests 1
# pass  1

# ok

[LizzHale]

Thanks for the reply, @kevinsawicki! Your sample works for me so it must have something to do with how I'm setting up the test? Here's my example:

var Application = require('spectron').Application
var test = require('tape')

// pass the path to the built application from the command line
var path = process.argv[2]

function setup() {
    app = new Application({
        path: path
    })
    return app.start()
}

function teardown() {
    if (app && app.isRunning()) {
        app.stop()
    }
}
function wrapper(description, fn) {
    test(description, function(t) {
        setup()
            .then(function() {
                return fn(t)
            })
            .then(function() {
                return teardown()
            })

    })
}
wrapper('upon application launch', function(t) {
    app.client.getWindowWidth().then(function(width) {
        t.equal(width, 900, 'client window width should equal 900')
    })
    t.end()
})

$ node test.js <path to electron executable>
TAP version 13
# upon application launch

1..0
# tests 0
# pass  0

# ok

[kevinsawicki]

Thanks for the example, I think it needed a few tweaks to properly chain all the promises together:

var Application = require('spectron').Application
var test = require('tape')

// pass the path to the built application from the command line
var path = process.argv[2]

var app = null

function setup() {
    app = new Application({
        path: path
    })
    return app.start()
}

function teardown(t) {
    if (app && app.isRunning()) {
        return app.stop().then(function () {
            t.end()
        }, function (error) {
            t.end(error)
        })
    } else {
        t.end()
    }
}
function wrapper(description, fn) {
    test(description, function(t) {
        setup()
            .then(function() {
                return fn(t)
            })
            .then(function() {
                return teardown(t)
            })

    })
}
wrapper('upon application launch', function(t) {
    return app.client.getWindowWidth().then(function(width) {
        t.equal(width, 900, 'client window width should equal 900')
    })
})

$ node test.js <path to electron executable>
TAP version 13
# upon application launch
ok 1 client window width should equal 900

1..1
# tests 1
# pass  1

# ok

[kevinsawicki]

I updated my previous comment to pass the failure from app.stop() to t.end so stopping errors would be reported.

[LizzHale]

Ah yes! That works perfectly and has the added bonus of forcing me to isolate my tests. Thank you so much for the help!

[kevinsawicki]

Thank you so much for the help!

My pleasure, happy to hear things are working now 👍