Comments (8)
Atom-shell guarantees that closing window would trigger beforeunload
and unload
event in javascript, so an infinite loop would block the close event. Simply make the x on window work would break this guarantee.
I'll add a way to make browser aware of the infinite loop in renderer, so users can choose to (1) force closing the window; (2) continue waiting; (3) interrupt the loop and report the stack trace.
from electron.
Yeah, a force close prompt would be great.
from electron.
This appears to have regressed.
from electron.
This appears to have regressed again.
from electron.
@nathansobo I can not reproduce with following steps:
- open devtools and run
while(true);
- click window's close button
- wait for 5s and the
Editor is not responding
dialog shows
from electron.
@zcbenz Strange. It's happening for me in certain specs, I think in situations where the spec pretty printer is trying to print way more than it can handle. If you put an endless loop in specs and run them, is it possible to reproduce?
from electron.
Seems that the unresponsive dialog is suppressed in specs:
https://github.com/atom/atom/blob/master/src/browser/atom-window.coffee#L96
from electron.
Wow, sorry about that.
from electron.
Related Issues (20)
- [Bug]: Most Electron apps delete all your bitmap fonts from your user font cache on Linux immediately upon startup. HOT 2
- [Feature Request]: Hardware accelerated off-screen rendering HOT 2
- [Bug]: recentDocuments not populating
- [Bug]: Crash when adding child view HOT 4
- Electron SIGSEGV Error When Running in Docker Container HOT 2
- [Bug]: HTML Drag and Drop API not returning event.dataTransfer.files array consistently on all Electron versions
- [Bug]: BrowserView's content is visually wiped when vibrancy is set on Electron version 30 and up
- [Bug]: node_modules/electron/dist/electron exited with signal SIGSEGV HOT 1
- [Bug]: Clicking on the color picker doesn't do anything HOT 4
- [Bug]: New Protocol.handle vs Protocol.registerFileProtocol does not fetch files properly.
- [Bug]: Crash base::subtle::RefCountedBase::ReleaseImpl() EXCEPTION_ACCESS_VIOLATION_READ HOT 1
- [Bug]: Capturing the screen is broken in the newer version (desktopCapturer) HOT 1
- gitHub.com/docker/repo
- [Feature Request]: add config.hideDock to BrowserWindow.setHiddenInMissionControl
- [Bug]: Calling session.defaultSession.webRequest.onHeadersReceived after ready and before window creation causes silent crash
- webContents.getPrintersAsync() not returning printer list on Linux Mint Cinnamon 19.1 HOT 3
- [Bug]: Frameless BrowserView.setAutoResize() is broken in v30.0.1
- [Infra]: Test check CI failed to execute because of npm package not found HOT 3
- [Bug]: <input type="file"> is not showing dialog on click HOT 4
- [Bug]: app.setLoginItemSettings({ openAtLogin: true }) doesnt work in APPX after publishing it.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron.