Giter Site home page Giter Site logo

Comments (4)

appdevopts avatar appdevopts commented on June 10, 2024

https://app.circleci.com/pipelines/github/electron/electron?branch=28-x-y&status=failed

Are there any one familiar with these codes could help to have a look on it?

Branch 28-x-y has already not been built and released about ONE month, which should be done weekly usually!!!

from electron.

appdevopts avatar appdevopts commented on June 10, 2024

This pr #42093 (Add support of the Worklet target) looks like trying to resolve this issue, but it seems that it does not work as expect!

https://github.com/electron/electron/pull/42093/files#diff-2c0a59a9393373bfbf3b76c74dd3406528da6e9df8b80a9a2ee52067c0d19c5aR38

from electron.

appdevopts avatar appdevopts commented on June 10, 2024

Why there are two similar folders name for devtools frontend?

https://github.com/electron/electron/tree/28-x-y/patches/devtools-frontend
https://github.com/electron/electron/tree/28-x-y/patches/devtools_frontend

The same folder name in chromium is:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend

So, it seems the "devtools-frontend" should be the correct folder name!

pr #40413 & #41895 import this wrong folder name

from electron.

clavin avatar clavin commented on June 10, 2024

Fixed in #42212.

from electron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.