Comments (5)
patuwwy
commented on July 28, 2024
The problem is caused by E0x effect in song.
As suggested by the author, I disabled setting filter in effect_t0_e0 function.
Thanks
from webaudio-mod-player.
sagamusix
commented on July 28, 2024
The effect_t0_e0 implementation is actually wrong, E0x enables the LED filter if x is even and disables it if x is odd. In particular, E00 enables the filter and E01 disables it. If implemented correctly, the Lotus music plays correctly.
from webaudio-mod-player.
electronoora
commented on July 28, 2024
Changed the Protracker E0x effect to only look at the least significant bit of the parameter.
from webaudio-mod-player.
sagamusix
commented on July 28, 2024
Looking at the code, it's still not quite correct: The filter should be disabled if the bit is set. Also, the " // look ahead at very first row to see if filter gets enabled" (line 280) needs to be updated accordingly.
from webaudio-mod-player.
electronoora
commented on July 28, 2024
Ah, damnit. Ok, should be fixed now.
https://mod.haxor.fi/Patrick_Phelan/l3_cd3_lotus3.mod
from webaudio-mod-player.
Related Issues (20)
- UI Performance Issues HOT 1
- XM player bugs and missing features
- Next step: The music tracker HOT 1
- Ui improvements HOT 1
- Pattern visualisation missing after manual load HOT 1
- Track visualiser floats down playing Mechanism Eight
- Not work with Raspbian on Rpi 3 HOT 1
- ImpulseTracker support HOT 2
- S3M file that uses Adlib samples doesn't play HOT 2
- Suggestion: rewrite file format handlers in Rust HOT 6
- Curious about the source of the last value in note period table. HOT 4
- Doesn't work if deployed under a directory HOT 1
- Impulse Tracker support HOT 1
- Locks up near the beginning when trying to play Dreamer's Black Queen module. HOT 2
- Better integration in other environments plus minor improvements
- Refactor to use AudioWorkletNode instead of ScriptProcessorNode
- Rewrite the UI to render entirely into a Canvas
- [req] Add a new song to mod.haxor.fi HOT 1
- Publish modules to npm with TypeScript types
- General cleanup HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webaudio-mod-player.