Giter Site home page Giter Site logo

Comments (5)

germanescobar avatar germanescobar commented on August 23, 2024

Added support to parameterize the data coding. The supported data codings are the following:
0 - Default
1 - ASCII
3 - Latin

Added a 'dataCoding' attribute to the SmppConfiguration class.
Added the logic to the SmppConnector class.
Fixed the test to validate that the data coding is being set.

from mokai.

yalomoush avatar yalomoush commented on August 23, 2024

Shouldn't add UCS2 encoding as well. to support 16-bit language like Arabic?

from mokai.

germanescobar avatar germanescobar commented on August 23, 2024

Yes, you are right. Thanks!

from mokai.

bigkahuna1uk avatar bigkahuna1uk commented on August 23, 2024

I agree that data coding should parameterizable and preferably should be a strategy to be plugged into the framework. Also why is USC2 chosen to be added rather than UTF-16?

from mokai.

yalomoush avatar yalomoush commented on August 23, 2024

I think according to SMPP v3.4 Protocol USC2 (UTF-16BE) is recommended encoding for language like Arabic, Japanese, Chinese, Hebrew. I do not know if UTF-16 would work with these languages.

from mokai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.