Theme Review Guidlines

[grappler]

Theme Review Guidlines

[elimc]

Thanks for the review. I am not particularly interested in going through the WP.org theme review, because this is not for the public. It is only for developers.

I'm not sure what you mean about the register_nav_function() issue. I am having that being called after_theme_setup in functions.php. Am I doing this wrong?

[grappler]

That is fine. It is just important that it is clear.

(I would still recommend placing the features in a site specific plugin that can easily be managed without the theme being involved.)

I don't think it is https://github.com/elimc/jumpstart/blob/master/lib/inc/custom-template-tags.php#L10
This is how it should be

function jumpstart_menu() {
    // This theme uses wp_nav_menu() in one location.
    register_nav_menus( array(
        'primary' => __( 'Primary Menu', '_s' ),
    ) );

}
add_action( 'after_setup_theme', 'jumpstart_menu' );

[elimc]

I am loading the bootstrap file from functions.php. In that file is where the add_action functionality takes place. This means that my menu is working fine when I load the theme. I have tested it.

I may consider moving modular functionality into a plugin later on. For now, it seems like things are working ok, and I will keep improving the theme.

[grappler]

The menu will work but adding by hooks is better. This is what Justin Tadlock says:

By adding everything from a hook, your functions file becomes much more organized and allows users to remove things using the remove_action() or remove_filter() functions. It also makes sure that things are loaded at their proper point in the WordPress flow.

http://justintadlock.com/archives/2010/12/30/wordpress-theme-function-files

I will close this issue as you are working on it. 😄