mix ecto.migrate -n argument has no effect

[elixir-ecto]

mix ecto.migrate -n argument has no effect

[josevalim]

Quick question: does it work with --step instead of -n? -- *José Valim* www.plataformatec.com.br Skype: jv.ptec Founder and Director of R&D

[bgentry]

Quick question: does it work with --step instead of -n?

Nope, the argument is also ignored with mix ecto.migrate --step 1 🙁

[josevalim]

Hi @bgentry, unfortunately I cannot reproduce this using latest ecto and ecto_sql. I just started a new Phoenix app, created two different resources and did this:

~/OSS/phoenix/installer/demo[master %]$ mix ecto.migrate -n 1
[debug] QUERY OK source="schema_migrations" db=0.3ms
SELECT s0."version"::bigint FROM "schema_migrations" AS s0 FOR UPDATE []
[info] == Running 20181222002903 Demo.Repo.Migrations.CreateUsers.change/0 forward
[info] create table users
[info] == Migrated 20181222002903 in 0.0s
~/OSS/phoenix/installer/demo[master %]$ mix ecto.migrate -n 1
[debug] QUERY OK source="schema_migrations" db=0.8ms
SELECT s0."version"::bigint FROM "schema_migrations" AS s0 FOR UPDATE []
[info] == Running 20181222002912 Demo.Repo.Migrations.CreatePosts.change/0 forward
[info] create table posts
[info] == Migrated 20181222002912 in 0.0s

Have you tried using latest ecto_sql and checked if the problem persists? If so, can you prodice a way to reproduce it? Thanks.

[bgentry]

@josevalim ahh, sorry to waste your time on this 🤦‍♂️ I suspect it must be due to this alias in our mix.exs:

  defp aliases do
    [
      "ecto.migrate": ["ecto.migrate", "ecto.dump"],
      ..
    ]
  end

I guess I'll have to come up with a different way to achieve that, one that doesn't swallow args.

[josevalim]

I have changed master to perform strict argument parsing, which we should have been doing along time ago:

$ mix ecto.dump -n 1
** (Mix) Could not invoke task "ecto.dump": 1 error found!
-n : Unknown option

Btw, you can change your alias to this:

def aliases do
  ["ecto.migrate": &migrate_and_dump/1]
end

defp migrate_and_dump(args) do
  Mix.Task.run "ecto.migrate", args
  Mix.Task.run "ecto.dump"
end

[bgentry]

@josevalim brilliant idea, thanks! Explicit rejection of invalid args will help prevent others from running into this class of problem. And also, thanks for the solution 😄