Giter Site home page Giter Site logo

Comments (10)

mhanberg avatar mhanberg commented on June 18, 2024 1

That is reasonable.

You would just need to make sure that it's still override-able by the user.

from wallaby.

antonioparisi avatar antonioparisi commented on June 18, 2024 1

nevermind, fixed it. since I'm running a custom session of Wallaby, I've set the binary option in the chromeOptions map

from wallaby.

dvic avatar dvic commented on June 18, 2024

Seems like an issue with chromedriver itself: https://bugs.chromium.org/p/chromedriver/issues/detail?id=4520&q=cannot%20find%20Chrome%20binary&can=2

from wallaby.

dvic avatar dvic commented on June 18, 2024

@mhanberg adding the binary option to chromeOptions resolves the issue, is this something you want to add as a (temporary) fix for this problem? Maybe it's even something we want anyways so that the used chrome version in chromedriver is always the same as the one wallaby detects?
image

from wallaby.

dvic avatar dvic commented on June 18, 2024

@mhanberg I see the fix is in [1] by the way, I was not aware of the Chrome for Testing binaries [2], we should probably add those as well in the detection algorithm?

[1] https://developer.chrome.com/blog/chrome-for-testing/
[2] https://developer.chrome.com/blog/chrome-for-testing/

from wallaby.

antonioparisi avatar antonioparisi commented on June 18, 2024

I've updated to {:wallaby, "~> 0.30.5"} but I'm still experiencing this issue, anyone else? I'm on osx and even by specifying the binary to /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome in the chromeOptions I'm still getting:

unknown error: no chrome binary at /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome

(Driver info: chromedriver=115.0.5790.102 (90efd4b0ad6aa15eeafcdabd5817ae939f7ba059-refs/branch-heads/5790_90@{#9}),platform=Mac OS X 13.5.0 arm64)

from wallaby.

dvic avatar dvic commented on June 18, 2024

How does your config for wallaby look like? Like this https://hexdocs.pm/wallaby/Wallaby.Chrome.html#module-chrome-binary?

from wallaby.

antonioparisi avatar antonioparisi commented on June 18, 2024

How does your config for wallaby look like? Like this https://hexdocs.pm/wallaby/Wallaby.Chrome.html#module-chrome-binary?

it does, yes.

config :wallaby, chromedriver: [
  path: System.get_env("CHROMEDRIVER_PATH"),
  binary: System.get_env("GOOGLE_CHROME_BIN")
]

GOOGLE_CHROME_BIN="/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome"
CHROMEDRIVER_PATH=/opt/homebrew/bin/chromedriver

from wallaby.

dvic avatar dvic commented on June 18, 2024

Can you double check the back ticks are properly parsed? (they should be omitted in the config right?) Iā€™d just try without env var just to be sure

from wallaby.

antonioparisi avatar antonioparisi commented on June 18, 2024

Can you double check the back ticks are properly parsed? (they should be omitted in the config right?) Iā€™d just try without env var just to be sure

I've just tried, still getting unknown error: cannot find Chrome binary
very weird.

just for sanity check:

      case Wallaby.start_session(
        readiness_timeout: 30_000,
        capabilities: %{
          javascriptEnabled: true,
          chromeOptions: %{
            args: [
              "--no-sandbox", "window-size=1280,800", "--disable-gpu",
              "--fullscreen"
            ]
          }
        }
      ) do
...
config :wallaby, chromedriver: [
  path: System.get_env("CHROMEDRIVER_PATH"),
  binary: System.get_env("GOOGLE_CHROME_BIN")
]
CHROMEDRIVER_PATH=/opt/homebrew/bin/chromedriver
GOOGLE_CHROME_BIN=/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome
unknown error: cannot find Chrome binary
(Driver info: chromedriver=115.0.5790.102 (90efd4b0ad6aa15eeafcdabd5817ae939f7ba059-refs/branch-heads/5790_90@{#9}),platform=Mac OS X 13.5.0 arm64)

from wallaby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.