Comments (2)
Hi Ben!
For some presets (like the density one) and certain use cases the size of the image does not represent the display size.
I would make this feature opt-in, probably by passing an option to the helper when defining a preset.
PRs are welcome!
from vite-plugin-image-presets.
Opt-in makes sense! I did take a look to see if I could quickly PR something, but IIUC the sharp image object is only accessed as part of srcset generation so it might be a reasonably big change
vite-plugin-image-presets/src/presets.ts
Line 40 in 44e5fb6
I'll take a closer look when I get a chance! Thanks for the excellent plugin 🌟
(FWIW this feature comes with https://github.com/dazuaz/responsive-loader which is what I'm migrating from)
from vite-plugin-image-presets.
Related Issues (14)
- Animated images Support HOT 1
- Possible vulnerability in sharp at 'npm install' time if an attacker has control over build environment
- Update NPM package HOT 1
- Use `rollupOptions.options.assetFileNames` when specified in the Vite config HOT 5
- Dynamic imports
- enhancement: string as the default export if the preset only defines srcset
- Can this work with import.meta.glob? HOT 1
- Example Image.vue with <style scoped> HOT 1
- Usage in raw HTML/Twig HOT 1
- `&src` argument gives bad `/@imagepresets/[id].[ext]` path (vite 5) HOT 3
- Add support for dynamic images HOT 1
- Cached images are re-written (and not used from cache) on each netlify deployment HOT 2
- [Feature Request] Default preset HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vite-plugin-image-presets.