Giter Site home page Giter Site logo

Does not build on Windows about elmish HOT 10 CLOSED

elmish avatar elmish commented on May 22, 2024
Does not build on Windows

from elmish.

Comments (10)

MangelMaxime avatar MangelMaxime commented on May 22, 2024 1

We was having the same problem for fable-arch.
If you upgrade Fake to a certain version, them it will look for npm.bat in your PATH variable.

Here is the commit fixing the problem for Fable-arch: fable-compiler/fable-arch@9aaf39d

from elmish.

et1975 avatar et1975 commented on May 22, 2024

That's true, the build infrastructure is weak ATM and it doesn't build on Windows.
Partially because I use OSX and partially because I don't believe paket should be installing npm as my local dependency. Also, I've switched a while ago to yarn, so even if it worked, it wouldn't be doing a proper job, i.e. a reproducible build.

Having said that, running yarn build in each of src subfolders (starting with elmish) should build on Windows (it did, last time I tried).

Thanks for bringing it to my attention again, I need to have a better build script and Travis/AppVeyor to go with it.

from elmish.

davidpodhola avatar davidpodhola commented on May 22, 2024

Thanks @et1975 and @MangelMaxime . Yes, I also do not believe npm should be installed locally. I have npm installed, but for some reason it is not detected by FAKE (?)

Anyway in samples it seems cp is used so it would not run anyway even with yarn I assume.

from elmish.

et1975 avatar et1975 commented on May 22, 2024

cp is used

Ah, yes... unless cp is an alias in PowerShell? Can't wait for linux subsystem to become mainstream on Windows :)

Anyway, even as it is, it's easy to fix - since all the web samples use webpack2 it would be fairly straightforward to either pack the styles from the node_modules or add a plugin to do the copying.

from elmish.

davidpodhola avatar davidpodhola commented on May 22, 2024

OK, thanks for the info will have a look at that next week.

from elmish.

et1975 avatar et1975 commented on May 22, 2024

If you check my fork, you'll see I've switched the build to yarn, it builds on AppVeyor and TravisCI now. Got into a weird Fable build problem trying to consolidate dev dependencies, but fake script is fine now.
The samples take a long time to build, so I'll keep them as an optional target. Still would like to see them building on Windows, so I'd appreciate the effort there!

from elmish.

et1975 avatar et1975 commented on May 22, 2024

The elmish projects should build now (see the updated readme).

from elmish.

davidpodhola avatar davidpodhola commented on May 22, 2024

build.cmd without parameters works now, great, thank you @et1975!
samples do not build; it is not only matter of cp, there are other path-related issues I think.

Will need to look at this more

capture

from elmish.

et1975 avatar et1975 commented on May 22, 2024

that was an error in [email protected], please upgrade to 0.8.2.
... I should unlist it.

from elmish.

davidpodhola avatar davidpodhola commented on May 22, 2024

Confirm, after upgrade it works. Now I try to test the react native samples on Windows too, but I think this is a different story so closing here, thanks again!

from elmish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.