Client 'on' params as an Object

[elpheria]

Client 'on' params as an Object

[mkozjak]

Would be handy if you attached an example and an error, if it's not a problem.

[sir-go]

I subscribe my Client to 'act.change' event:

ws.on('act.change', p => {console.log(p)})

and on

{"jsonrpc":"2.0","notification":"act.change","params":{"id":"59ad722f7520c26f1249fe29"}}

notification I see 'undefined' in the console due to "params" is an Object and params.length === undefined,

https://github.com/qaap/rpc-websockets/blob/c335c872f8ea46df06848d21ac57df30457322d7/src/lib/client.js#L225

for (let i = 0; i < message.params.length; i++) {
 // ... will never happen
}

Sorry I dunno how to show a full-working example, it's a part of the big Client (vuejs) - Server (golang) application.

[sir-go]

I made a custom json.Marshal for encoding any notification params as an array on the server-side, it works but it's sad.

[mkozjak]

Thanks!!! Will take a look into it asap!

[mkozjak]

@msergdeez: Fixed in master! Can you use that one 'till I do a full release? Have some other things to do before publishing...

[sir-go]

Awesome! Thanks for the response!

[mkozjak]

@msergdeez: 3.5.0 including the fix is now published!