Giter Site home page Giter Site logo

Comments (3)

eltos avatar eltos commented on May 18, 2024

Sure, nothing else is to be expected as you are calling the build method of SimpleDialog then.
I expected people to realise this right away (or call the constructor directly), but you are totally right it's missing in the wiki (sorry having wasted your time :/). I just added it to the wiki. Thanks for your feedback.

What do you think about adding the following to CustomViewDialog? This will hopefully save other people's time as well.

public static CustomViewDialog build(){
    throw new java.lang.InstantiationError("Unintended abuse of the builder method. " +
            "Have you created your own build() method in your custom dialog?");
}

from simpledialogfragments.

AngeloAvv avatar AngeloAvv commented on May 18, 2024

Well it could be a good practice throwing an exception if someone uses the builder but doesn't call the right one. Anyway don't feel sorry about that, we're here to help each other :)
BTW I just need to say thank you about this wonderful library, I do really appreciate your work 👍

from simpledialogfragments.

eltos avatar eltos commented on May 18, 2024

Thanks :)

from simpledialogfragments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.