Comments (5)
There's actually a really simple solution on Tetra's end, I think. There's a method Item#canApplyAtEnchantingTable
Forge provides to specify which enchantments are compatible with a given item. It doesn't seem that Tetra overrides this, and as far as I can it is not used in the Tetra codebase at all. Simply overriding this to prevent enchantments being applied should fix the issue with Eidolon and potentially with other future enchanting mods.
If mickelus is unwilling to do this I can also make a tag, but I am currently in the midst of a larger content update so I can't say when I'd be able to release it. It's also a less robust solution in general, I think, so I'd prefer to avoid it.
from eidolon.
Is Tetra using the default enchantment tag to store modifiers? Eidolon definitely checks that the item is either:
- enchantable
- already enchanted
- a book
I can see that Tetra modular tools return false for enchantable, and they clearly aren't books, so the only thing I can think of at the moment that would cause this is if Tetra puts its modifiers under the Enchantments
tag.
It's not immediately clear to me, then, if this should be fixed on Eidolon's or Tetra's side. I think the best solution would be for Tetra to simply use another tag, if the "enchantments" it uses aren't actually acquired by enchanting. But I can see from the code that that would be a fairly invasive change. I'll try and figure out a check I can do on my end. Merely checking isEnchantable
isn't sufficient, since the Soul Enchanter is meant to enchant already-enchanted items. Worst-case scenario I could just manually check for Tetra items, but that's not very robust.
from eidolon.
Tetra most likely puts its modifiers under the Enchantments tag: They are enchantments, but they are applied by placing books within the tool, through the Tetra Workbench.
We had a similar issue with the Industrial Foregoing Enchantment Extractor, the dev's solution was to blacklist items based on a tag, in this case called industrialforegoing:enchantment_extractor_blacklist
. Perhaps you could add and check a similar tag?
from eidolon.
@mickelus There is a Tetra enchant compatibility issue, please read above :)
from eidolon.
I've got separate fields in the nbt tag for my modules & modifiers, when those change I populate the Enchantments
tag based on the modifiers that are "enchantments". If the Enchantments
tag is modified by something else it will be overwritten the next time the modules or modifiers changes for the item.
from eidolon.
Related Issues (20)
- Feature Request - dimension config whitelist HOT 1
- Ritual doesn't repell slimes.
- Magic Workbench recipes don't use datapacks, so they can't be changed by modpack developers HOT 7
- Zombie Brutes don't create Zombie Villagers
- Crash while lighting a brazier
- Crash when using soulfire wand (Likely incompatibility)
- Server - Failed to save chunk HOT 1
- Flint and Bronze not working for Eidolon rituals
- Ritual of Purifying does not keep NBT of Zombified Mobs
- Reaper's Scythe referred to as "Reaper Scythe" in Ars Ecclesia
- Book Ars Ecclesia HOT 1
- [1.16.5][0.2.7] Possible memory leakage
- [Req] Ability to right-click items into the crucible.
- Cant fill the crucible with water HOT 1
- Burning pillager banners doesnt give me bad omen HOT 2
- Crystallization ritual freezes game.
- Worktable dupe glitch
- Enhancement: pewter
- Deactivate Time Rituals
- Soul sign does not unlock after 50+ sacrifices HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eidolon.