Giter Site home page Giter Site logo

if we want to do this ... about citar HOT 6 CLOSED

emacs-citar avatar emacs-citar commented on July 19, 2024
if we want to do this ...

from citar.

Comments (6)

mtreca avatar mtreca commented on July 19, 2024 1

Hi @bdarcus, thanks a lot for the invitation. I am interested in collaborating for this package. I am still pretty busy at work, but I will probably take half a day this week to catch up on different threads regarding the project and think about how I could contribute best to this project. Thanks for your involvement!

from citar.

mtreca avatar mtreca commented on July 19, 2024 1

Hi again. I sadly still do not really have time on the project, but it seems that my help is not really needed at this point. Stellar work on this package! The elisp looks really clean and the whole integration with completion-read and the emabrk ecosystem is very elegant. I will be happy to test it and provide feedback.

from citar.

bdarcus avatar bdarcus commented on July 19, 2024

Sounds good.

It looks like it will be a couple of weeks before Titus can look at our PRs, so that gives you some time too.

The key changes I made on my code are on the key --read functions.

The embark author also helped me optimize the completing-read function.

I ended up merging the two code bases here in the repo, as it turned out to be easy.

The more I think about it, I think there's big value in integrating the change directly into bibtex-completion, and I think I prefer that.

But if not, there's little benefit in hosting a separate package there, and significant downside.

Doing it here, however, gives us flexibility to make any changes at our own pace; not just to the code, but also documentation, etc.

And I expect as selectrum et al take off, there will be more people interested in this sort of solution, and so possibility for helpful PRs, etc.

from citar.

bdarcus avatar bdarcus commented on July 19, 2024

I've decided to focus on this, more than the PR, as stuff can always be moved back, and it's just much easier to manage with a separate repo, issue tracker, etc., and without having to worry about legacy stuff.

Plus I setup the CLI to warn me if any of the elisp was problematic, which it does well.

I have a couple of open issues and PRs @mtreca, if you have any feedback.

from citar.

bdarcus avatar bdarcus commented on July 19, 2024

Yeah, to bring you up-to-speed, main changes I made was to remove the macro (for simplicity and flexibility), and to switch to completing-read-multiple. Also, changed map to cl-loop.

from citar.

bdarcus avatar bdarcus commented on July 19, 2024

Also, for what I'm working on now, see #37.

from citar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.