Comments (5)
Wouldn't the best answer be to make the upstream
bibtex-completion-format-entry
configurable, which would make it easier to extend on the original package. Is that what your open PR upstream aims at doing?
Yes.
I think I can figure it out. PR now opened.
from citar.
I think you mean the substring match within the candidate?
If yes, I think that's because we use the display property, but search against a different string.
I just tested ivy-bibtex
, and it does indeed highlight matches, despite using a display transformer, which I understand is the same as me using a display
property here.
I'll submit an issue to selectrum on this, and see what they say.
from citar.
I'll submit an issue to selectrum on this, and see what they say.
Daniel has been explaining the options. You can read that thread to understand.
The trick is how to keep everything good about the current implementation (user configurable search, ability to search for presence of pdfs and notes, and fully configurable display and suffix/annotation) but adding what you're looking for.
It's possible it''s a PITA, or that it's really easy; not sure yet :-)
from citar.
Brainstorming:
What if:
- the candidate string itself is generated from
bibtex-completion-format-entry
, which means that content will have the match highlighted - put the additional metadata important to search on an "invisible" property; maybe this is also generated by a template using
bibtex-completion-format-entry
? This part won't be highlighted, of course.
WDYT @mtreca?
from citar.
Hi @bdarcus, sorry, I am quite busy with work at the moment, so it might take me a while to anwser.
I read the thread you linked, and I think I agree with minad when stating that this trade-off is not great for the end user who will expect highlighting to work similarly everywhere, including bibtex-actions. Hence, I think using bibtex-completion-format-entry
(which, if I understood correctly, would fix the highlighting issue) is preferable, especially if it makes it easier to potentially merge back in bibtex-completion
later on (I don't know if you intend to do that).
Wouldn't the best answer be to make the upstream bibtex-completion-format-entry
configurable, which would make it easier to extend on the original package. Is that what your open PR upstream aims at doing?
from citar.
Related Issues (20)
- Add error handling for citar-bibliography
- Make use of, or remove, `citar-additional-fields`
- Add an extensions folder
- Function "citar-indicator-create" not found HOT 7
- citar docs in emacs manual HOT 1
- Add new major-mode-functions?
- file indicator incorrectly indicating HOT 19
- Error in using 'citar-insert-citation' HOT 2
- can't act on `embark-export` result s HOT 1
- Preload cache in the background HOT 8
- Expand test coverage, integrate into CI
- Using `nerd-icons` for `citar-symbols` leads to use of default values (`F`, `N`, `L`) instead HOT 2
- embark-define-keymap has been removed HOT 5
- when selecting multiple references, keep the current filter HOT 2
- Discrepancies in citation format when using `citar-insert-reference` HOT 7
- add an "other window'/"other frame" option for opening notes HOT 17
- prefixes and suffixes in `citar-markdown-insert-citation` HOT 6
- Only citation key being used for narrowing results HOT 6
- Request for Nerd Icons Integration in Citar HOT 4
- Error with inserting citation in LaTeX file: "No such file or directory tex-site" HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from citar.