No selection highlighting

[emacs-citar]

No selection highlighting

[bdarcus]

Wouldn't the best answer be to make the upstream bibtex-completion-format-entry configurable, which would make it easier to extend on the original package. Is that what your open PR upstream aims at doing?

Yes.

I think I can figure it out. PR now opened.

[bdarcus]

I think you mean the substring match within the candidate?

If yes, I think that's because we use the display property, but search against a different string.

I just tested ivy-bibtex, and it does indeed highlight matches, despite using a display transformer, which I understand is the same as me using a display property here.

I'll submit an issue to selectrum on this, and see what they say.

[bdarcus]

I'll submit an issue to selectrum on this, and see what they say.

Daniel has been explaining the options. You can read that thread to understand.

The trick is how to keep everything good about the current implementation (user configurable search, ability to search for presence of pdfs and notes, and fully configurable display and suffix/annotation) but adding what you're looking for.

It's possible it''s a PITA, or that it's really easy; not sure yet :-)

[bdarcus]

Brainstorming:

What if:

1. the candidate string itself is generated from bibtex-completion-format-entry, which means that content will have the match highlighted
2. put the additional metadata important to search on an "invisible" property; maybe this is also generated by a template using bibtex-completion-format-entry? This part won't be highlighted, of course.

WDYT @mtreca?

[mtreca]

Hi @bdarcus, sorry, I am quite busy with work at the moment, so it might take me a while to anwser.

I read the thread you linked, and I think I agree with minad when stating that this trade-off is not great for the end user who will expect highlighting to work similarly everywhere, including bibtex-actions. Hence, I think using bibtex-completion-format-entry (which, if I understood correctly, would fix the highlighting issue) is preferable, especially if it makes it easier to potentially merge back in bibtex-completion later on (I don't know if you intend to do that).

Wouldn't the best answer be to make the upstream bibtex-completion-format-entry configurable, which would make it easier to extend on the original package. Is that what your open PR upstream aims at doing?