Comments (7)
Hummm… the code causing the problem is that for dealing with D-specific static if/else issues. It appears to have been written on the assumption that add-function
and the others were added in 24.0 rather than 24.4. I think the code must have been added after I switched to 24.4 as I have never seen the problem. At first sight the correct immediate fix would be to amend the version check to ensure > 24.3. However this would then leave a lot of new, but old, unfixed bugs for people using 24.[0123], until someone wrote the equivalent functionality without add-function
etc. I guess this is a judgement call for those using 24.[0123] which is the lesser of two evils.
from emacs-d-mode.
As an experiment, I have added extra version checks in the code I believe is problematic. I only have 24.4 and 24.5 so I cannot check for the problem and its resolution. I have pushed a branch with the fix to my GitHub repository: https://github.com/russel/Emacs-D-Mode/tree/advice-issue. If you check this compared to the official version to see if it makes any difference. Also if you could post a small code file that enables you to see the problem that would be helpful.
from emacs-d-mode.
I tried it with precisely the same rresults as bevore (same warning during build and same message in emacs at runtime). The code I used is the sample on the frontpage on dlang.org (without shebang and comment). Pasted it into emacs, went to line 5, pressed , went to line 6, pressed again which doesn't work anymore. The error appears when I press the second time (in line 6).
from emacs-d-mode.
I made a PR #51 that at least should enable using d-mode in Emacs versions before 24.4. It's correct at least from the point of view of not using old style defadvice with the new macros add-function/remove-function.
from emacs-d-mode.
I committed this change to master, so it should appear in MELPA soon. I will delete my tinkering branch.
from emacs-d-mode.
So can this be closed, then?
from emacs-d-mode.
Yes let's close this issue. If the problem resurfaces, a new issue can be started (which is probably better than reopening this one).
from emacs-d-mode.
Related Issues (20)
- Emacs 27.1 regression ? HOT 2
- Identifier `function` is not highlighted as keyword HOT 2
- Wrong indentation for 'else version'
- Enum members not highlighted after `deprecated`
- Wrong syntax highlight for WYSIWYG strings HOT 3
- Incorrect indentation of align(N) aggregate
- Missing fontification of member function names returning a typeof(this) HOT 2
- Wrong indentation for `catch` after `try` in brace-less `if`
- Error when missing strings and unbalanced parenthesis HOT 9
- Inconsistent `enum` highlighting (type name and members) HOT 3
- Adjust indention of attribute colon qualifier
- README.md says this software is GPLv2 which is not coherent with the COPYING file
- Escapes within backtip nested in string are ignored HOT 1
- MELPA package appears broken HOT 2
- Dead project? HOT 1
- Use cc-mode syntax parsing for imenu?
- Parenthesis-const/immutable qualified function parameters and return types HOT 4
- Cannot find function rx-form HOT 2
- wrong-type-argument error when triggering electric mode HOT 3
- Please do not bundle undercover HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from emacs-d-mode.