Comments (12)
How did you disable the icons for regular treemacs? You can customize the icon theme of lsp-treemacs using the lsp-treemacs-theme
variable, so perhaps you could set some icon theme that has no icons for it.
from lsp-treemacs.
In treemacs one can set a variable like this :
(setq treemacs-no-png-images t)
I'm not sure how changing the theme would affect the behavior of my current theme, it'd be just easier not to have them tbh
from lsp-treemacs.
If you are happy with sacrificing the arrows, I could offer the following (temporary!) kludge, until we actually implement this properly (so don't close this issue yet):
(eval-after-load 'lsp-treemacs (defun lsp-treemacs--generic-icon (&rest _) ""))
Here is how it would look on latest treemacs master + lsp-mode master:
from lsp-treemacs.
That wouldn't be an issue for me ! This is how my treemacs
looks for reference
And like this when I "unroll" it :
So that's just good old treemacs without any fluff aside from the symbols that indicate a different level in the tree structure.
Thanks for getting back to me!
from lsp-treemacs.
In treemacs one can set a variable like this :
(setq treemacs-no-png-images t)I'm not sure how changing the theme would affect the behavior of my current theme, it'd be just easier not to have them tbh
I see that lsp-treemacs.el
always calls treemacs-get-icon-value
with second parameter nil
. That second parameter indicates whether the TUI version of the icon should be used (when non-nil) or the GUI version (when nil
). I may be wrong here as I'm not familiar with the treemacs code, or Emacs Lisp for that matter, but lsp-treemacs
could take the value of treemacs-no-png-images
into account. That it doesn't appear to do so may be by design, I don't know.
To disable the use of icons I locally replaced the nil
in the call to treemacs-get-icon-value
by treemacs-no-ping-images
, which I've set to t
. It works for the use case I have.
from lsp-treemacs.
@nbfalcon if implemented, would this proposed feature/switch also solve doomemacs/themes#500? if not, shall i open a separate issue?
from lsp-treemacs.
No, that is unrelated (this is lsp-treemacs
, not normal treemacs
)
from lsp-treemacs.
The issue only appears once lsp-mode
starts up, so I'm pretty sure it's an lsp-treemacs
issue.
from lsp-treemacs.
Upon further inspection, this is probably related. Can you check with the triage/ugly-icons
branch on my fork? Note that this is not a proper fix, and is only to find out if this is due to lsp-treemacs
, as it will probably break lots of icons in the latter.
from lsp-treemacs.
it works! no icon issues present when i use that branch (none that i can see anyway, with the "doom-colors" theme; i don't mean to suggest it's not breaking other stuff as you mentioned).
from lsp-treemacs.
Great! So the issue here is that we are modifying the "Default" treemacs theme, and replacing some icons which were probably provided by all-the-icons
with png
icons. The former uses a font and so they are vector graphics and scale well, while the latter ones are raster graphics and don't. The icons that are needlessly overridden in lsp-treemacs-icons
would need to be examined. Note that this is unrelated to this issue, though.
from lsp-treemacs.
got it 👍 i opened a new issue, see above
from lsp-treemacs.
Related Issues (20)
- dap-ui-sessions: Symbol’s value as variable is void: treemacs-\'lsp-treemacs-generic-root-extension-instance HOT 12
- make lsp-treemacs-call-hierarchy show location of call instead of only the caller's name
- No thread selected when debugging HOT 6
- Error when calling dap-ui-locals: (void-variable lsp-treemacs-generic-root) HOT 16
- doom emacs with java lsp error
- Expand by default HOT 1
- Treemacs not updating with `vue-semantic-server`
- Features' requests for symbols' tree: follow mode support + settings for folding depth on startup
- minor mode keymap missing?
- Error list keeps showing old cached results after the first render HOT 5
- lsp-treemacs-errors-list just appends to buffer, can't expand nodes HOT 3
- Error processing message (void-function icon). HOT 11
- Symbol's function definition is void: action HOT 1
- Icons of the LSP symbols are not being shown HOT 4
- `lsp-treemacs-call-hierarchy` doesn't work HOT 2
- file-missing "Cannot open load file" "No such file or directory" "treemacs-treelib" HOT 1
- How do you get views to open automatically
- Selecting windows
- Reusing a window with `treemacs-RET-action`
- Does `lsp-treemacs-errors-list` modify `treemacs-select-window`?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lsp-treemacs.