Giter Site home page Giter Site logo

Comments (12)

nbfalcon avatar nbfalcon commented on August 11, 2024

How did you disable the icons for regular treemacs? You can customize the icon theme of lsp-treemacs using the lsp-treemacs-theme variable, so perhaps you could set some icon theme that has no icons for it.

from lsp-treemacs.

Nathan-Furnal avatar Nathan-Furnal commented on August 11, 2024

In treemacs one can set a variable like this :

(setq treemacs-no-png-images t)

I'm not sure how changing the theme would affect the behavior of my current theme, it'd be just easier not to have them tbh

from lsp-treemacs.

nbfalcon avatar nbfalcon commented on August 11, 2024

If you are happy with sacrificing the arrows, I could offer the following (temporary!) kludge, until we actually implement this properly (so don't close this issue yet):

(eval-after-load 'lsp-treemacs (defun lsp-treemacs--generic-icon (&rest _) ""))

Here is how it would look on latest treemacs master + lsp-mode master:
20201112-180325

from lsp-treemacs.

Nathan-Furnal avatar Nathan-Furnal commented on August 11, 2024

That wouldn't be an issue for me ! This is how my treemacs looks for reference

Screenshot_20201112_180851
And like this when I "unroll" it :

Screenshot_20201112_181122

So that's just good old treemacs without any fluff aside from the symbols that indicate a different level in the tree structure.

Thanks for getting back to me!

from lsp-treemacs.

swinkels avatar swinkels commented on August 11, 2024

In treemacs one can set a variable like this :

(setq treemacs-no-png-images t)

I'm not sure how changing the theme would affect the behavior of my current theme, it'd be just easier not to have them tbh

I see that lsp-treemacs.el always calls treemacs-get-icon-value with second parameter nil. That second parameter indicates whether the TUI version of the icon should be used (when non-nil) or the GUI version (when nil). I may be wrong here as I'm not familiar with the treemacs code, or Emacs Lisp for that matter, but lsp-treemacs could take the value of treemacs-no-png-images into account. That it doesn't appear to do so may be by design, I don't know.

To disable the use of icons I locally replaced the nil in the call to treemacs-get-icon-value by treemacs-no-ping-images, which I've set to t. It works for the use case I have.

from lsp-treemacs.

eeshugerman avatar eeshugerman commented on August 11, 2024

@nbfalcon if implemented, would this proposed feature/switch also solve doomemacs/themes#500? if not, shall i open a separate issue?

from lsp-treemacs.

nbfalcon avatar nbfalcon commented on August 11, 2024

No, that is unrelated (this is lsp-treemacs, not normal treemacs)

from lsp-treemacs.

eeshugerman avatar eeshugerman commented on August 11, 2024

The issue only appears once lsp-mode starts up, so I'm pretty sure it's an lsp-treemacs issue.

from lsp-treemacs.

nbfalcon avatar nbfalcon commented on August 11, 2024

Upon further inspection, this is probably related. Can you check with the triage/ugly-icons branch on my fork? Note that this is not a proper fix, and is only to find out if this is due to lsp-treemacs, as it will probably break lots of icons in the latter.

from lsp-treemacs.

eeshugerman avatar eeshugerman commented on August 11, 2024

it works! no icon issues present when i use that branch (none that i can see anyway, with the "doom-colors" theme; i don't mean to suggest it's not breaking other stuff as you mentioned).

from lsp-treemacs.

nbfalcon avatar nbfalcon commented on August 11, 2024

Great! So the issue here is that we are modifying the "Default" treemacs theme, and replacing some icons which were probably provided by all-the-icons with png icons. The former uses a font and so they are vector graphics and scale well, while the latter ones are raster graphics and don't. The icons that are needlessly overridden in lsp-treemacs-icons would need to be examined. Note that this is unrelated to this issue, though.

from lsp-treemacs.

eeshugerman avatar eeshugerman commented on August 11, 2024

got it 👍 i opened a new issue, see above

from lsp-treemacs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.