doc-render issue in 29

[seagle0128]

doc-render issue in 29

[ianyepan]

Same thing in Emacs 28.2. Happens with the clangd server. Those faces inherit markdown-code-face, by the way.

Edit: this happened only very recently. It was working well for the past few years.

[jcs090218]

Was it working earlier? The recent relevant commit is emacs-lsp/lsp-mode@e2a1b5f; not sure if this is the cause. 😕

[def-SpaceWar]

I also have Emacs 28.2 and I get the same error in CSharp.

• OS: Linux
• Distro: Gentoo
• Emacs: 28.2
• Lsp-ui: Built off of master using straight.el.

But it also sometimes works.

And this error is only recent, not something I was experiencing before.

[stonekyx]

Looks like emacs-lsp/lsp-mode@e2a1b5f (emacs-lsp/lsp-mode#3844) is indeed related. Removing the following function call in lsp--fontlock-with-mode fixes it for me:

(when (eq mode 'lsp--render-markdown)
              (lsp--fix-markdown-links))

[jcs090218]

@vspinu Can you help us here?

[vspinu]

Something is throwing there and you get the plain string instead. To be frank I think that try error logic could be improved. Falling back to plain str is too conservative IMO. I think the buffer string should be returned regardless, in case of errors the buffer string is likely to be better formatted anyhow.