Giter Site home page Giter Site logo

Comments (4)

jcs090218 avatar jcs090218 commented on May 25, 2024

Hmm... this may sounds like a trouble! What would you propose to fix this issue? Add documentation? Code fix? etc.

from sideline-flycheck.

blahgeek avatar blahgeek commented on May 25, 2024

Well I guess ideally we should eliminate the async process mixed by the two different timers. I can think of two ways:

  1. Only keep the flycheck-display-error-at-point timer, synchronously call sideline-render in it. I think it should work if flycheck is the only backend, but not sure if it's possible for multiple backends.
  2. Only keep the sideline-render timer, call flycheck-display-error-at-point in it to gather the output and return synchronously. This seems better?

How do you think?

from sideline-flycheck.

blahgeek avatar blahgeek commented on May 25, 2024

Only keep the sideline-render timer, call flycheck-display-error-at-point in it to gather the output and return synchronously. This seems better?

The problem of this approach is that, the re-rendering of sideline (currently based on if the symbol-at-point is different?) may not correctly update flycheck errors (e.g. one symbol contains multiple errors at different chars?)

from sideline-flycheck.

jcs090218 avatar jcs090218 commented on May 25, 2024

The first option sounds like more trouble since you will force render other backends as well. I would go for the second option if we go for code fix!

I suggest to add a note to the README so users acknowledge this issue. Having multiple timers seems to be normal in Emacs world, albeit awkward. I don't want to abandon flycheck's timer since it opens option to users, so other frontend packages may co-exists with this plugin. They should able to cancel other UI frontends if they only want sideline to be the only to appear on the screen.

from sideline-flycheck.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.