Giter Site home page Giter Site logo

Comments (9)

ClaudioWayne avatar ClaudioWayne commented on July 28, 2024

It seems to be that plaintext is ignored other file types are working. so i guess A is solved.
Thx

from thephish.

emalderson avatar emalderson commented on July 28, 2024

Hello, thanks for having taken the time to thoroughly explain the problems you have faced.

A) - Attachments are not parsed

As you have already found out, the problem is only with the plaintext files. This is because I have never encountered an email with a plaintext file as an attachment, so this behavior has never been tested. However, I have already identified the problem and it is solvable by adding a couple lines of code to consider the Content-Disposition MIME header, so I will fix this bug in the next commit.

B) - html-tags for hyperlinks gets recolonized as part of the URL

This seems to be a problem of the the library that I use to parse the IoCs (which is ioc-finder). I don't know if this problem is known by the maintainer or if it has been solved in any new commit, so I'll probably test the latest release of the library with some URLs and I hope I'll be able to reproduce this behavior. For this, I would be grateful if you could send me the email you have used so that I can test with the same URLs, since I've never faced this problem before. Maybe I can try to add some workaround and parse the already parsed observables to remove those characters related to HTML tags.

C) - mini report from the URL-Haus Analyzer is not shown in observables

That's quite odd. I am not able to reproduce this problem. Anyway this is a TheHive/Cortex problem since the analyzer is correctly started by ThePhish and the mini-reports are handled by TheHive.

from thephish.

ClaudioWayne avatar ClaudioWayne commented on July 28, 2024

Hi thx for reply. How should i send you the mail?

from thephish.

emalderson avatar emalderson commented on July 28, 2024

As an attachment to [email protected]

from thephish.

ClaudioWayne avatar ClaudioWayne commented on July 28, 2024

done

from thephish.

emalderson avatar emalderson commented on July 28, 2024

I haven't received anything

from thephish.

ClaudioWayne avatar ClaudioWayne commented on July 28, 2024

Maybe Spam?!
Send you the mail attached as zip again.

from thephish.

emalderson avatar emalderson commented on July 28, 2024

Ok, I have received the email. It seems that the URL is recognised twice (from the href attribute of the anchor element and from the content of that element) and only one of them contains the >< characters. I'll try to solve this problem, but in the meantime this should not invalidate the result of the analysis, since the link that contains the tag elements won't be recognized as malicious by any analyzer, while the correct one would, so the email would be marked as malicious anyway.

from thephish.

emalderson avatar emalderson commented on July 28, 2024

Bug fixed with the latest commit.

from thephish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.