Giter Site home page Giter Site logo

Run tests from pods about rfcs HOT 9 CLOSED

ember-cli avatar ember-cli commented on July 16, 2024
Run tests from pods

from rfcs.

Comments (9)

webark avatar webark commented on July 16, 2024

@keithkelly this has been brought up in emberjs/rfcs#124 Might want to look at what they're talking about and add your reaction or ideas as this is a part of the proposal.

from rfcs.

stefanpenner avatar stefanpenner commented on July 16, 2024

tests in pods, and then being able to run only tests from a pod or two, seems like a great idea.

from rfcs.

nathanhammond avatar nathanhammond commented on July 16, 2024

Tests in "pods" makes sense, and there really isn't anything preventing us from doing something like that right now: ember test "module/name/*/glob/**/regex/maybe?" which would run a build and filter tests to be included (getting clever about module/fs matching).

However, with the advent of better module selection inside of Qunit itself I'm not sure how much sense this makes? Maybe for CI mode?

/cc @trentmwillis

from rfcs.

rwjblue avatar rwjblue commented on July 16, 2024

This is related to the module normalization and testing unification RFC's. When those two RFC's are implemented this should "just work".

from rfcs.

trentmwillis avatar trentmwillis commented on July 16, 2024

I personally dislike co-locating test code and app code. That said, I think after the module RFC lands, this could make more sense. Some questions to consider:

  • Where do test-helpers live?
  • Where do acceptance tests live? Specifically, tests that are not tied to a specific route or span multiple routes.
  • How would this affect linting configs? I imagine many folks have slightly different linting rules for test code than they do for app code (ex: more allowed globals).

from rfcs.

stefanpenner avatar stefanpenner commented on July 16, 2024

Where do test-helpers live?

wherever they make sense contextually

Where do acceptance tests live? Specifically, tests that are not tied to a specific route or span multiple routes.

sibling to engines/apps

How would this affect linting configs? I imagine many folks have slightly different linting rules for test code than they do for app code (ex: more allowed globals).

I would imagine pods could contain a test dir, that could contain the specific linting rules, Although yes this does seem bad.

from rfcs.

stefanpenner avatar stefanpenner commented on July 16, 2024

@trentmwillis i believe the value here would be for unit level test, tests that are highly contextual. Atleast that is the thought.

from rfcs.

MiguelMadero avatar MiguelMadero commented on July 16, 2024

This is related to ember-cli/ember-cli#4461

from rfcs.

rwjblue avatar rwjblue commented on July 16, 2024

We are working on closing the ember-cli/rfcs repo in favor of using a single central RFC's repo for everything. This was laid out in https://emberjs.github.io/rfcs/0300-rfc-process-update.html.

Sorry for the troubles, but would you mind reviewing to see if this is still something we need, and if so migrating this over to emberjs/rfcs?

from rfcs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.