Comments (5)
I'm not familiar enough with the internals to be sure, but I imagine the rough todo is something like
-
add a
_visitRoute
function to the sandbox context. This function would roughly do the work ofbuildAppInstance
andvisitRoute
today (ie build the application instance and visit the route) -
change
visitRoute
to invoke_visitRoute
on the sandbox.
from fastboot.
Yes, that path forward seems correct to me.
@kratiahuja - Does that look right to you also?
from fastboot.
Yes, we would also need to make sure the FastBoot result is outside the sandbox so that we can serialize and send the template.
But otherwise at high level it looks correct to me. I'll try finding the branch where I started some of this work last year.
from fastboot.
Ok, so I did a spike of the above proposed option. However, prototype extensions still don't work in one usecase: When I define something outside of the sandbox (example sandboxGlobals) and access it inside the sandbox, it still does not work. Therefore it will still not work when a communication happens through najax. I believe this is how node releams work.
I can put out a PR otherwise but the above usecase will still not work.
from fastboot.
@kratiahuja - I'm curious if you still have that WIP spike laying around locally. I'd be happy to dust it off and see about pushing it forward...
from fastboot.
Related Issues (20)
- Deprecate resilient mode HOT 11
- Disabling Fastboot during deploy HOT 1
- Changing the FastBoot runtime environment HOT 3
- FastBoot.require is broken when running locally HOT 7
- Ember array methods HOT 2
- [SOLVED] ReferenceError: crypto is not defined (octane) HOT 3
- Refactor `sandboxGlobals` options into `buildSandboxGlobals`
- Refactor `destroyAppInstanceInMs` system
- Move Application and ApplicationInstance creation into VM sandbox
- Drop `najax` global by default? HOT 5
- Block elements inside `p` cause rehydration failures HOT 2
- Drop `FastBoot.require` for 3rd dependencies? HOT 5
- An in-range update of resolve is breaking the build 🚨 HOT 5
- Fastboot 3.0.0 error
- An in-range update of eslint-plugin-node is breaking the build 🚨 HOT 1
- Update Shoebox Documentation
- Cannot wait for promises after model hooks HOT 4
- Quickstart is not working HOT 3
- /snapshots directory is included and balloons the package size HOT 2
- ChainAlert: npm package release (3.2.0) has no matching tag in this repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastboot.