Giter Site home page Giter Site logo

Comments (5)

hjdivad avatar hjdivad commented on July 26, 2024

I'm not familiar enough with the internals to be sure, but I imagine the rough todo is something like

  1. add a _visitRoute function to the sandbox context. This function would roughly do the work of buildAppInstance and visitRoute today (ie build the application instance and visit the route)

  2. change visitRoute to invoke _visitRoute on the sandbox.

from fastboot.

rwjblue avatar rwjblue commented on July 26, 2024

Yes, that path forward seems correct to me.

@kratiahuja - Does that look right to you also?

from fastboot.

kratiahuja avatar kratiahuja commented on July 26, 2024

Yes, we would also need to make sure the FastBoot result is outside the sandbox so that we can serialize and send the template.

But otherwise at high level it looks correct to me. I'll try finding the branch where I started some of this work last year.

from fastboot.

kratiahuja avatar kratiahuja commented on July 26, 2024

Ok, so I did a spike of the above proposed option. However, prototype extensions still don't work in one usecase: When I define something outside of the sandbox (example sandboxGlobals) and access it inside the sandbox, it still does not work. Therefore it will still not work when a communication happens through najax. I believe this is how node releams work.

I can put out a PR otherwise but the above usecase will still not work.

from fastboot.

rwjblue avatar rwjblue commented on July 26, 2024

@kratiahuja - I'm curious if you still have that WIP spike laying around locally. I'd be happy to dust it off and see about pushing it forward...

from fastboot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.