Comments (6)
I think the Result
class is only used once visit
has resolved at which time the Ember app should not be able to change anything anymore.
from fastboot.
With addons like ember-cli-head this might be problematic I guess? As <head>
might be re-rendered after route transitions.
from fastboot.
To be clear, this issue is not about streaming responses during rendering (which has a number of issues as well). I think generally speaking the suggested changes here are a good idea...
from fastboot.
Isn't shoebox already created when visit
is done? How is it going to be beneficial to send shoebox responses in chunks?
from fastboot.
Right, this issue is mostly about sending the main doc and the shoebox in 2 chunks after visit
has resolved and the response has been rendered so that large shoeboxes don’t block rendering. The problem Joanie that if you have a 1MB shoebox, all of that 1MB has to be downloaded before the page can be rendered while if the main doc and the shoebox are sent in 2 chunks, the browser can render the page while downloading the huge shoebox. This makes using the shoebox Wayne’s costly.
from fastboot.
Oho I see what you mean now. Yeah this totally makes sense to me. The suggested changes seem good to me provided they are an opt-in.
from fastboot.
Related Issues (20)
- Deprecate resilient mode HOT 11
- Disabling Fastboot during deploy HOT 1
- Changing the FastBoot runtime environment HOT 3
- FastBoot.require is broken when running locally HOT 7
- Ember array methods HOT 2
- [SOLVED] ReferenceError: crypto is not defined (octane) HOT 3
- Refactor `sandboxGlobals` options into `buildSandboxGlobals`
- Refactor `destroyAppInstanceInMs` system
- Move Application and ApplicationInstance creation into VM sandbox
- Drop `najax` global by default? HOT 5
- Block elements inside `p` cause rehydration failures HOT 2
- Drop `FastBoot.require` for 3rd dependencies? HOT 5
- An in-range update of resolve is breaking the build 🚨 HOT 5
- Fastboot 3.0.0 error
- An in-range update of eslint-plugin-node is breaking the build 🚨 HOT 1
- Update Shoebox Documentation
- Cannot wait for promises after model hooks HOT 4
- Quickstart is not working HOT 3
- /snapshots directory is included and balloons the package size HOT 2
- ChainAlert: npm package release (3.2.0) has no matching tag in this repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastboot.