Comments (5)
toddjordan
commented on May 23, 2024
@hankfanchiu thanks for the feedback. I'm not entirely sure the app needs lodash. I'll do some experimenting and see if I can remove the dependency, otherwise I'll do as you suggest.
from super-rentals.
toddjordan
commented on May 23, 2024
Hey, looks like we need lodash for mirage. I was able to reproduce the issue using npm 3. Adding a note in the readme
from super-rentals.
toddjordan
commented on May 23, 2024
Ok, tried this out with the latest versions of ember and it now works with npm3. See PR #20 for a reference of what I updated.
Closing this issue when the PR gets merged.
from super-rentals.
toddjordan
commented on May 23, 2024
Merged PR, closing
from super-rentals.
hankfanchiu
commented on May 23, 2024
Awesome, thanks for looking into it @toddjordan
from super-rentals.
Related Issues (20)
- Google-Map-API is no longer free as in free (payment card required) HOT 1
- Update code to use `{{this.property}}` syntax where appropriate HOT 2
- Convert to angle brackets components
- Convert the super rentals app to the Octane preview HOT 5
- Remove use of jQuery HOT 1
- Fix linting issues on the Octane branch
- mapbox API key required?
- License
- Install instructions do NOT work HOT 2
- Move branches around HOT 1
- where is the css file? HOT 2
- Link to introduction part2 is broken HOT 1
- a11y quick wins : lang attribute in index.html HOT 1
- a11y quick wins: Having landmarks for pages/components HOT 4
- search on demo app does not work HOT 3
- [Suggestion] Copy/Paste Issue
- Alternative to yarn install HOT 1
- Google Maps API error HOT 12
- Include Google maps elevation and direction service
- Missing / incomplete integration test HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from super-rentals.