Comments (5)
Can you send the relevant PRs please? Thank you!
from super-rentals.
I've submitted a PR. Once you accept it, I'll create one for the guides repository.
from super-rentals.
Merged PR. Looks like someone beat you to the fix in guides in emberjs/guides#1549
from super-rentals.
@toddjordan good to see it's been fixed in the guides, but now the variable naming isn't the same in the guides as in the reference app. Should this be fixed?
from super-rentals.
Ah, sure. submit a PR aligning the new variable name with your
super-rental PR and I'll merge. Thanks!
On Mon, Jul 4, 2016 at 2:56 AM Guust Nieuwenhuis [email protected]
wrote:
@toddjordan https://github.com/toddjordan good to see it's been fixed
in the guides, but now the variable naming isn't the same in the guides as
in the reference app. Should this be fixed?—
You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub
#28 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADcR5w8Rkd0B7kKKcGG7iKXNcA879iC4ks5qSK6CgaJpZM4I8m6u
.
from super-rentals.
Related Issues (20)
- Google-Map-API is no longer free as in free (payment card required) HOT 1
- Update code to use `{{this.property}}` syntax where appropriate HOT 2
- Convert to angle brackets components
- Convert the super rentals app to the Octane preview HOT 5
- Remove use of jQuery HOT 1
- Fix linting issues on the Octane branch
- mapbox API key required?
- License
- Install instructions do NOT work HOT 2
- Move branches around HOT 1
- where is the css file? HOT 2
- Link to introduction part2 is broken HOT 1
- a11y quick wins : lang attribute in index.html HOT 1
- a11y quick wins: Having landmarks for pages/components HOT 4
- search on demo app does not work HOT 3
- [Suggestion] Copy/Paste Issue
- Alternative to yarn install HOT 1
- Google Maps API error HOT 12
- Include Google maps elevation and direction service
- Missing / incomplete integration test HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from super-rentals.