Giter Site home page Giter Site logo

GoogleMaps error about super-rentals HOT 5 CLOSED

ember-learn avatar ember-learn commented on May 23, 2024
GoogleMaps error

from super-rentals.

Comments (5)

locks avatar locks commented on May 23, 2024

Can you send the relevant PRs please? Thank you!

from super-rentals.

guustnieuwenhuis avatar guustnieuwenhuis commented on May 23, 2024

I've submitted a PR. Once you accept it, I'll create one for the guides repository.

from super-rentals.

toddjordan avatar toddjordan commented on May 23, 2024

Merged PR. Looks like someone beat you to the fix in guides in emberjs/guides#1549

from super-rentals.

guustnieuwenhuis avatar guustnieuwenhuis commented on May 23, 2024

@toddjordan good to see it's been fixed in the guides, but now the variable naming isn't the same in the guides as in the reference app. Should this be fixed?

from super-rentals.

toddjordan avatar toddjordan commented on May 23, 2024

Ah, sure. submit a PR aligning the new variable name with your
super-rental PR and I'll merge. Thanks!

On Mon, Jul 4, 2016 at 2:56 AM Guust Nieuwenhuis [email protected]
wrote:

@toddjordan https://github.com/toddjordan good to see it's been fixed
in the guides, but now the variable naming isn't the same in the guides as
in the reference app. Should this be fixed?


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#28 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADcR5w8Rkd0B7kKKcGG7iKXNcA879iC4ks5qSK6CgaJpZM4I8m6u
.

from super-rentals.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.