Comments (8)
Sorry about the delay.
In the current implementation (without your commit), same classes and CSS rules are applied:
I think this is a problem that needs a hacky solution, probably better suited into MaterialUI libs (or even at DuckDcukGo!), which would need to detect the browser and apply hack solution on buggy browsers. I've just opened an issue there about this problem.
from covid.
@emibcn I can fix this one too if you want?
from covid.
@ashish979 Its yours!
from covid.
Hi @emibcn
I have raised PR for this fix #27
I verified the fix on my android device (chrome browser) but please check once on other mobile browser too and let me know if the fix is ok.
from covid.
Hi @emibcn
Sorry for the delay, been busy with some important tasks.
I tried replicating the issue on firefox browser on an android device but could not successfully replicate it. Can you please help me with the device version and browser version so that I can check if the issue still exists?
Below is the screenshot from my device:
Also I have raise PR #31 as per your suggestion adding paperFullScreen
. Please test if this fixes the issue.
from covid.
Hi @ashish979 ,
Note: You don't need to remove and recreate a PR: just push new commits to the branch you were working on and them will be visible in the PR while it is open.
Also I have raise PR #31 as per your suggestion adding
paperFullScreen
. Please test if this fixes the issue.
About the fix you provided in #31 : paperFullScreen
property is not intended to be used like that (did you read the docs provided in the comment #27 (comment) ?).
from covid.
I tried replicating the issue on firefox browser on an android device but could not successfully replicate it. Can you please help me with the device version and browser version so that I can check if the issue still exists?
I use DuckDuckGo browser app, which I thought it was a fork of Firefox, but now I see it might not be like that...
from covid.
About the fix you provided in #31 :
paperFullScreen
property is not intended to be used like that (did you read the docs provided in the comment #27 (comment) ?).
Hi @emibcn
I did read the docs and used the property as mentioned. paperFullScreen
is adding some styles when the fullScreen
property is true.
And in the actual implementation:
I can see these styles applied in my browser:
Can't say what I am missing here. Please suggest.
from covid.
Related Issues (20)
- Maps widget is not updating on time slide HOT 1
- (JS-0466) Prefer React components to have a `shouldComponentUpdate` method
- (JS-0463) Consider adding `propTypes` to the React component definition
- (JS-0752) `label` tags should have a text label and an associated control
- (JS-0128) Should not have unused variables
- (JS-0393) Prevent missing displayName in a React component definition
- (JS-0393) Prevent missing displayName in a React component definition
- (JS-0129) Variable used before definition
- (JS-0128) Should not have unused variables
- (JS-0128) Should not have unused variables
- Widget/Slider.jsx: (JS-0128) Should not have unused variables
- Widget/Slider/PlayPause.jsx: (JS-0463) Consider adding `propTypes` to the React component definition
- (JS-0128) Should not have unused variables
- Move Backends logic to a Data Context Provider/Consumer logic (allow easy backend adding) HOT 6
- Add widget to consume BCN's timeline
- Add visual mark on App Menu opener when app update is available
- Add unit tests with `jest` HOT 1
- Improve backends context provider/consumers
- Add ESLint to CI/CD
- Add data source "Evolució dels casos, altes hospitalàries i defuncions per Covid-19 a Catalunya"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from covid.