Comments (8)
can I take this?
from covid.
@Abhijith126 Of course!
from covid.
Please feel free to assign this ticket to me. I will fork and start work on this.
from covid.
Please feel free to assign this ticket to me. I will fork and start work on this.
Done!
from covid.
@emibcn, I have added a new Menu, Language after About.
Once selected the below dialog appears. Is this the expected behavior?
Also, how do you want to display the list of Languages?.
Let me know your thoughts on this,
from covid.
Looks good!
A couple of thoughts:
- Use some Material UI element (for example, https://material-ui.com/components/radio-buttons/ )
- Show actual language name instead of code and remove duplicates, something like (not tested; would need to add
name
attribute on each language):
const keys = Object.keys(available);
keys
// From https://www.javascripttutorial.net/array/javascript-remove-duplicates-from-array/
.filter((key, index) => {
return keys.indexOf(key) !== index;
})
from covid.
I have created a PR with the changes and added translations for words like language based on google translate. This needs to be verified.
Please check and let me know if any changes are required.
from covid.
Commented on #19 (review)
from covid.
Related Issues (20)
- Maps widget is not updating on time slide HOT 1
- (JS-0466) Prefer React components to have a `shouldComponentUpdate` method
- (JS-0463) Consider adding `propTypes` to the React component definition
- (JS-0752) `label` tags should have a text label and an associated control
- (JS-0128) Should not have unused variables
- (JS-0393) Prevent missing displayName in a React component definition
- (JS-0393) Prevent missing displayName in a React component definition
- (JS-0129) Variable used before definition
- (JS-0128) Should not have unused variables
- (JS-0128) Should not have unused variables
- Widget/Slider.jsx: (JS-0128) Should not have unused variables
- Widget/Slider/PlayPause.jsx: (JS-0463) Consider adding `propTypes` to the React component definition
- (JS-0128) Should not have unused variables
- Move Backends logic to a Data Context Provider/Consumer logic (allow easy backend adding) HOT 6
- Add widget to consume BCN's timeline
- Add visual mark on App Menu opener when app update is available
- Add unit tests with `jest` HOT 1
- Improve backends context provider/consumers
- Add ESLint to CI/CD
- Add data source "Evolució dels casos, altes hospitalàries i defuncions per Covid-19 a Catalunya"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from covid.