Giter Site home page Giter Site logo

Comments (7)

apaleyes avatar apaleyes commented on June 26, 2024

I can confirm that it's a bit flacky, but not nearly as bad as 50% for me. Running this test locally, it fails once every 20 runs or so. Is that worse for you @mmahsereci ?

from emukit.

apaleyes avatar apaleyes commented on June 26, 2024

Starting to suspect this might be related to #291

from emukit.

mmahsereci avatar mmahsereci commented on June 26, 2024

I can confirm that it's a bit flacky, but not nearly as bad as 50% for me. Running this test locally, it fails once every 20 runs or so. Is that worse for you @mmahsereci ?

It failed repeatedly during my last PRs which was quite annoying. If I had to guess it was more often than every 20 times. Did not try locally.

from emukit.

mmahsereci avatar mmahsereci commented on June 26, 2024

It seems that there are two more tests failing now. These ones do not seem to be simply flaky but there are some shape and index errors.

  • tests/emukit/bayesian_optimization/test_bayesian_optimization_loop.py::test_loop[3]
  • tests/emukit/bayesian_optimization/test_local_penalization_calculator.py::test_local_penalization

See e.g.,
https://github.com/EmuKit/emukit/runs/7689362107?check_suite_focus=true

from emukit.

mmahsereci avatar mmahsereci commented on June 26, 2024

Perhaps it's due to scipy again. They released version 1.9.0 some days ago and the failed tests seem to be using it while the tests that pass use an older version

https://docs.scipy.org/doc/scipy/release.1.9.0.html

from emukit.

apaleyes avatar apaleyes commented on June 26, 2024

It was scipy indeed. Some explanation is in the fixing PR. Tests should be passing again!

from emukit.

mmahsereci avatar mmahsereci commented on June 26, 2024

Closing since it should be fixed by #437 .

from emukit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.