Giter Site home page Giter Site logo

Comments (4)

mxschmitt avatar mxschmitt commented on August 15, 2024 1

I can confirm that this works for us. Appreciate!

from reclient-configs.

ola-rozenfeld avatar ola-rozenfeld commented on August 15, 2024

Hmm, we have Chromium builds on Windows, and what worked was running both scripts with cmd, e.g.:

cmd.exe /c "python3 reclient-configs\configure_reclient.py --src_dir=%SRC_PATH%"

So Windows can run python3, it just needs some convincing :-)

I'm a wary that the change might backfire with existing users, e.g. Brave. To make it backward compatible we'd probably need to clone both scripts and have a python version alongside a python3 version, which is just not quite worth it, imo.

from reclient-configs.

mxschmitt avatar mxschmitt commented on August 15, 2024

hm weird! So when I installed Python officially there was only python and no python3 in my PATH. Sounds like python/cpython#99185.

TL;DR: python3 will target the WindowsStore Python while python will target the actual python.exe.

I have a workaround for now, so happy to close, just confusing and I thought python is what tools use nowadays.

What convention does Chromium use upstream? Looks like python3.

from reclient-configs.

ola-rozenfeld avatar ola-rozenfeld commented on August 15, 2024

What convention does Chromium use upstream? Looks like python3.

AFAIK, Chromium migrated to python3 everywhere and now relies on the Python version to be at least 3.8.

However: I just realized that I think I can fix your problem with just this: #8
Can you try this out, please? Thank you!

from reclient-configs.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.