Giter Site home page Giter Site logo

Comments (3)

Bobsimonoff avatar Bobsimonoff commented on July 28, 2024

I reviewed the Perl code. I decided to take the following approach since I do not know Perl well enough to modify it:

  1. cleaned up the GWAS file (removed the almost 40k of rows that do not comply with the rs regex check
  2. broke the catalog file into multiple pieces using an algorithm that keeps associated rsids in the same file where associated means rs1, rs2 and rs3 need to go in the same file if one study includes rs1 and rs2 but another includes rs2 and rs3
  3. Ran the files in parallel
  4. uncompressed the processed files, combined them, and recompressed them

This cur my initial run time down to a couple of hours.

from vep_plugins.

nakib103 avatar nakib103 commented on July 28, 2024

Hello @Bobsimonoff ,

Thanks again for looking into the plugin.

Yes, as you mentioned, the plugin does not use buffer and read the whole (filtered) file into memory and thus became a memory extensive operation. I will update the mechanism to reduce memory usage. On the contrary, reducing run time would not be as easy with large file size. The silver lining is that creating the processed file is not supposed to run frequently.

I will update you here once we have some optimisation in place. In the meantime, you can continue file split method that you are currently using.

Thank you for notifying us about the issue.

Best regards,
Nakib

from vep_plugins.

nakib103 avatar nakib103 commented on July 28, 2024

Hello @Bobsimonoff,

We have added improvement on the plugin,

  • memory: load only one line from the file into memory instead of the whole file.
  • runtime: the long run time was caused by database queries to retrieve variant location information. By default, now this is retrieved from the GWAS data file instead. But, you can still use database, if you want, by providing db=1 option.

This features will be available in the next Ensembl release 112. I will close this issue but if you face further problems feel free to open a new one.

Best regards,
Nakib

from vep_plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.