Comments (1)
When this task is implemented, the following patch should be reverted:
Subject: [PATCH] workaround for https://github.com/enso-org/enso/issues/10412
---
Index: test/Snowflake_Tests/src/Snowflake_Spec.enso
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/test/Snowflake_Tests/src/Snowflake_Spec.enso b/test/Snowflake_Tests/src/Snowflake_Spec.enso
--- a/test/Snowflake_Tests/src/Snowflake_Spec.enso (revision dfeeaa207ecceedf129f8fb93f05a5ac84d6a859)
+++ b/test/Snowflake_Tests/src/Snowflake_Spec.enso (revision 0d192541be6a8ef0eb0659d226aee1b7dddbd3cf)
@@ -568,7 +568,7 @@
Common_Spec.add_specs suite_builder prefix create_connection_fn
common_selection = Common_Table_Operations.Main.Test_Selection.Config supports_case_sensitive_columns=True order_by_unicode_normalization_by_default=True allows_mixed_type_comparisons=False fixed_length_text_columns=True removes_trailing_whitespace_casting_from_char_to_varchar=True supports_decimal_type=True supported_replace_params=supported_replace_params run_advanced_edge_case_tests_by_default=False
- aggregate_selection = Common_Table_Operations.Aggregate_Spec.Test_Selection.Config first_last=False first_last_row_order=False aggregation_problems=False
+ aggregate_selection = Common_Table_Operations.Aggregate_Spec.Test_Selection.Config first_last=False first_last_row_order=False aggregation_problems=False text_concat=False
agg_in_memory_table = ((Project_Description.new enso_dev.Table_Tests).data / "data.csv") . read
agg_table_fn = _->
Index: test/Table_Tests/src/Common_Table_Operations/Aggregate_Spec.enso
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/test/Table_Tests/src/Common_Table_Operations/Aggregate_Spec.enso b/test/Table_Tests/src/Common_Table_Operations/Aggregate_Spec.enso
--- a/test/Table_Tests/src/Common_Table_Operations/Aggregate_Spec.enso (revision dfeeaa207ecceedf129f8fb93f05a5ac84d6a859)
+++ b/test/Table_Tests/src/Common_Table_Operations/Aggregate_Spec.enso (revision 0d192541be6a8ef0eb0659d226aee1b7dddbd3cf)
@@ -908,6 +908,20 @@
materialized.columns.at 1 . name . should_equal "Shortest B"
materialized.columns.at 1 . to_vector . should_equal ["f"]
+
+ # Special case for Snowflake until the https://github.com/enso-org/enso/issues/10412 ticket is resolved.
+ if setup.prefix.contains "Snowflake" then
+ suite_builder.group prefix+"Table.aggregate Concatenate" group_builder->
+ group_builder.specify "should be supported" <|
+ table = table_builder [["X", ["A", "B", "C"]]]
+ result = table.aggregate columns=[(Concatenate "X")]
+ result.row_count . should_equal 1
+ str = result.at 0 . at 0
+ # No assumptions about ordering
+ str . should_contain "A"
+ str . should_contain "B"
+ str . should_contain "C"
+
suite_builder.group prefix+"Table.aggregate Concatenate" (pending = resolve_pending test_selection.text_concat) group_builder->
build_sorted_table table_structure =
# Workaround for https://github.com/enso-org/enso/issues/10321
@@ -1597,7 +1611,7 @@
expect_sum_and_unsupported_errors 2 <|
table.aggregate columns=[Sum "X", Shortest "Y", Longest "Y"]
- if test_selection.text_concat.not then
+ if test_selection.text_concat.not && (setup.prefix.contains "Snowflake" . not) then
group_builder.specify "with Concatenate" <|
table = table_builder [["X", [1,2,3]], ["Y", ["a", "bb", "ccc"]]]
expect_sum_and_unsupported_errors 1 <|
from enso.
Related Issues (20)
- Cannot connect to ydoc server in the newest nightly HOT 1
- Use Tanstack for Language Server client
- Toast text cannot be copied
- Strange error when entering unapplied collapsed method
- Importing extension methods ignores `hiding` and ignores methods imported by name (only `all` works) HOT 1
- Make `Decimal` constructors private HOT 1
- RuntimeManagementTest is not shutting down Threads properly
- TCK Truffle tests are leaking memory
- Dev tools button always visible in installed version
- Review token security
- Fix MapBox token
- Add dropdown indicator arrows to the table Viz menu buttons
- Seemingly invalid syntax accepted without errors? HOT 4
- Inserting a table with `Nothing` values into the Database fails in a confusing way if defaults are used HOT 2
- Uploading data into Snowflake is slow
- Reduce copying when manipulating IR through compiler passes HOT 3
- Remove AliasAnalysis metadata from LocalScope HOT 1
- `Table.order_by` fails on Snowflake if `..Case_Sensitive` ordering is specified
- Speedup `EnsoRootNode.buildFrameDescriptor`
- Visual indication of selection action
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from enso.