Giter Site home page Giter Site logo

Comments (7)

KalebMatthews avatar KalebMatthews commented on May 27, 2024 1

Just wanted to mention that the name given from the automatic linking process is different than the file names in the download link for manual linking. The only way I can see to make this package 100% on the setup is to either add the renaming of the files if you link the fonts manually in the readme or change the link to install the fonts to be a package you put up with the naming that matches the automatic names.

Just thought I would give y'all a heads up incase you were unaware of this. It's a TINY thing but since this issue already deals with it I thought I would include it here.

Here are the names given for the automatic linking process:

  • FontAwesome5_Regular
  • FontAwesome5_Solid
  • FontAwesome5_Brands

from react-native-fontawesome.

glasje avatar glasje commented on May 27, 2024

with help I can solve it .. I leave the link
#55

from react-native-fontawesome.

leandrosimoes avatar leandrosimoes commented on May 27, 2024

There is a PR for this here: #52

from react-native-fontawesome.

jgcmarins avatar jgcmarins commented on May 27, 2024

@leandrosimoes are we ready to merge?

from react-native-fontawesome.

leandrosimoes avatar leandrosimoes commented on May 27, 2024

@jgcmarins Yes, I think so, you already approved my PR, tell me if you need anything else.

from react-native-fontawesome.

leandrosimoes avatar leandrosimoes commented on May 27, 2024

I open a PR with that solves the hyphens problem, allowing to use the original files with hyphens. #61

In this PR has a working sample project to so you can see how to use properly, because there are some breaking changes on it.

from react-native-fontawesome.

leandrosimoes avatar leandrosimoes commented on May 27, 2024

A new version was released, please, check if in the new version this problem was fixed and feel free to reopen this issue if wasn't.

PS: REMEBER TO SEE THE NEW DOCUMENTATION BECAUSE THERE ARE SOME BREAKING CHANGES

from react-native-fontawesome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.