enyancc/vscode-ext-node-module-resolve

Node modules resolve plugin for VSCode

vscode-ext-node-module-resolve's Issues

Open file in new tab?

Hey there,

This extension appears to always open the new file in the same tab, instead of opening the file in a new tab. Maybe if the user held shift it would open the file in a new tab?

Thanks!

unneeded promise

I was looking at your code and noticed you return a promise https://github.com/sergiirocks/vscode-ext-node-module-resolve/blob/master/src/lib/module-extractor.js#L23 even thoough the whole logic is synchronous.

Maybe it would be worth making it synchronous and using Promise.resolve(value) wherever you're using it?

add jsx "JavaScript React" support

Please, can you add "onLanguage:javascriptreact" to your awesome package?
Thank you.

Regards.

Broken since vsc 1.5

This seems to have broken after upgrading to vsc 1.5.

Doesn't work when try to import .less file

Hi,
This extension is very help until I found this little inconvenience.
I have a directory structure like this.

app/
  src/
   A.jsx
   B.less

in A.jsx:
import './B.less';

when I wanted to import style from file B.less into A.jsx, but it does not work.And I notice this is related to function filterEs6 in src/lib/definition-provider.js. Maybe in there can be a bypass for *.less, *.css. Looking forward to your reply.

Extension not working

It appears that this extension is now broken, and unmaintained (last change occured 2 years ago, at the time of writing this).

1. Not working, with example:

Consider this basic CommonJS (require()) syntax for importing the Express web framework:

var express = require('express');
var app = express();
app.set('port', process.env.PORT || 3000);

With the cursor on the last line's set symbol, calling the Go to definition (F12) VSCode function, gives the error No definition found for 'set'.

Instead, it should resolve the node_modules directory hierarchy (located in the same directory as the file with above snippet).

Specifically it should resolve the /node_modules/express/lib/application.js file, on the line:

app.set = function set(setting, val) {

Mind you I have disabled the TSServer with:
"typescript.disableAutomaticTypeAcquisition": true
in order to disable the default behaviour which sends theg user to the index.d.ts file upon Go to definition.

2. Documentation on README is misleading when there is no 'Get Started' section:

Still confused? Click "Get Started" above.

How can you set custom NODE_PATH?

I couldn't figure out how to set a custom NODE_PATH variable

Doesn't work with custom root in Webpack

Hi,
This extension worked for me just fine. Until now. Let's say I have a directory structure like this.

app/
   src/
      module-1/
         A.js
      module-2/
      shared/
         B.js

I used to import using relative path. So, when I wanted to import someExportedItem from file B.js into A.js, I wrote import like this...

import {someExportedItem} from '../shared/B'

...and I was able to navigate to file B.js by Ctrl+Click on someExportedItem.
Today, I added root option into my webpack config, so I can use import path relative to src

root: [
   path.resolve('./src')
]

...and now it doesn't work anymore. Only navigation through Ctrl+Click on B in the path string works.
Not a big deal of course, but I think this should be configurable somehow via settings.